Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an empty array to the deprecated checkout endpoint #668

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Return an empty array to the deprecated checkout endpoint #668

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
21238a8
feat: return empty array to a deprecated endpoint
vsseixaso Sep 3, 2024
53fc071
Release v2.171.1-beta
vsseixaso Sep 3, 2024
980975d
add changelog
vsseixaso Sep 3, 2024
23d6287
Update manifest.json
vsseixaso Sep 3, 2024
01c881a
Update CHANGELOG.md
vsseixaso Sep 3, 2024
6ab8e0b
fix changelog
vsseixaso Sep 3, 2024
46c09fc
Merge branch 'feat/resolve-deprecated-endpoint' of github.com:vtex-ap…
vsseixaso Sep 3, 2024
ea2e582
Merge branch 'master' into feat/resolve-deprecated-endpoint
vsseixaso Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Deprecated
- Checkout orders endpoint. Now returns empty array
vsseixaso marked this conversation as resolved.
Show resolved Hide resolved

## [2.171.0] - 2024-06-28

### Fixed
Expand Down Expand Up @@ -2469,3 +2472,7 @@ Added documentSchema query to make it possible for retrieving masterdata schema
### Added

- **Resolver** Login resolver to provide GraphQL queries and mutations.


[Unreleased]: https://github.com/vtex-apps/store-graphql/compare/v2.171.1-beta...HEAD
[2.171.1-beta]: https://github.com/vtex-apps/store-graphql/compare/v2.171.0...v2.171.1-beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, we don't need to add beta and unreleased tags

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, removed.

2 changes: 1 addition & 1 deletion manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"vendor": "vtex",
"name": "store-graphql",
"version": "2.171.0",
"version": "2.171.1-beta",
vsseixaso marked this conversation as resolved.
Show resolved Hide resolved
"title": "GraphQL API for the VTEX store APIs",
"description": "GraphQL schema and resolvers for the VTEX API for the catalog and orders.",
"credentialType": "absolute",
Expand Down
9 changes: 8 additions & 1 deletion node/clients/checkout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,15 @@ export class Checkout extends JanusClient {
})
}

// Deprecated: This endpoint is deprecated and any request will return an empty array
public orders = () =>
this.get(this.routes.orders, { metric: 'checkout-orders' })
this.get(this.routes.orders, { metric: 'checkout-orders' }).catch((err) => {
if (err.response && err.response.status === 405) {
return []
}

throw err
})

public simulation = (simulation: SimulationPayload) =>
this.post<SimulationOrderForm>(
Expand Down
Loading