Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se option.label não é um número, Number.isNaN(option.label) retorna false, e o operador ! inverte isso para true. Portanto, qualquer valor não numérico ou válido será considerado "não-NaN" e fará o teste every retornar true indevidamente.
A lógica foi alterada para !isNaN(Number(option.label)
What problem is this solving?
A prop sortVariationsByLabel não estava funcional
How to test it?
Set the prop sortVariationsByLabel on sku-selector block to true
Screenshots or example usage:
Before
https://hanesdev--hanes.myvtex.com/0mhb005/p?skuId=180
After
How does this PR make you feel? 🔗
![https://giphy.com/gifs/dont-understand-rousseenragee-toutfeutoutcam-rHNCLQk0wDTjEUXRw0]