Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sku selector on plp #1106

Merged
merged 4 commits into from
Jul 9, 2024
Merged

fix: update sku selector on plp #1106

merged 4 commits into from
Jul 9, 2024

Conversation

cdcs0128
Copy link
Contributor

@cdcs0128 cdcs0128 commented May 7, 2024

What problem is this solving?

Fix to the KI 341322 ( https://vtexhelp.zendesk.com/agent/tickets/341322 ) update SKU selector in plp after change SKU in quickview

How to test it?

you could test the fix in this workspace

https://vtexsku--partnerspruebascol.myvtex.com/apparel/sony?initialMap=c&initialQuery=apparel&map=category-1,brand

  1. Go to any store that has a quick view and sku-selector.
  2. Pick an SKU and go to the quick view mode
  3. Change the SKU inside the quick view modal
  4. Exit quick view mode and you will notice that the sku didn't change, it just changed inside the quick view context

Workspace

Screenshots or example usage:

https://www.loom.com/share/f74bcda6646c4d89a660b4f2a2f0a6f5?sid=b4134cb1-3c2b-440b-b69e-e58c6cd6704a

How does this PR make you feel? 🔗

@cdcs0128 cdcs0128 requested a review from a team as a code owner May 7, 2024 21:02
Copy link
Contributor

vtex-io-ci-cd bot commented May 7, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@ArthurTriis1 ArthurTriis1 removed their request for review May 27, 2024 11:50
Copy link
Contributor

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@iago1501 iago1501 merged commit 1e87095 into master Jul 9, 2024
4 of 5 checks passed
@iago1501 iago1501 deleted the KI-341322/sku-selector branch July 9, 2024 14:54
Copy link
Contributor

vtex-io-ci-cd bot commented Jul 9, 2024

Your PR has been merged! App is being published. 🚀
Version 3.173.0 → 3.173.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants