-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: getPaymentInfo only returning one payment method #200
base: master
Are you sure you want to change the base?
Conversation
… BankInvoiceSection
… BankInvoiceSection
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
What problem is this solving?
In orders where the bank invoice payment method wasn't the first payment of the first transaction, its information wasn't displayed on the order placed page
How should this be manually tested?
There are 2 use cases for this change:
Screenshots or example usage
Example of an order with a bank invoice in the second payment of the array, where its information is not displayed:
https://gaboulstore.myvtex.com/checkout/orderPlaced/?og=1486610500025
Example of the same order, but in a workspace with this change implemented:
https://iespinoza2--gaboulstore.myvtex.com/checkout/orderPlaced/?og=1486610500025
Just a disclaimer, since this bank invoice doesn't have a URL, I just removed this validation in the workspace because I didn't have any other example to test
Types of changes
With this solution I think we might close: #199