Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SSR settings #42

Closed
wants to merge 2 commits into from
Closed

Remove SSR settings #42

wants to merge 2 commits into from

Conversation

jorgeAcostaVTEX
Copy link
Contributor

What problem is this solving?

Offers still being sent due to SSR settings

How to test it?

Check page source and look for "offers"
Workspace

Screenshots or example usage:

image

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@jorgeAcostaVTEX jorgeAcostaVTEX requested a review from a team as a code owner March 8, 2024 22:33
@jorgeAcostaVTEX jorgeAcostaVTEX requested review from hellofanny, lucasfp13 and lariciamota and removed request for a team March 8, 2024 22:33
Copy link
Contributor

vtex-io-ci-cd bot commented Mar 8, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Mar 8, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@iago1501
Copy link

iago1501 commented Apr 1, 2024

Hi @jorgeAcostaVTEX , why not simply remove the offers when in closed tp instead of adding an app flag and changing the ssr?

Also, I'm not confident about increase server load time just to get the app settings here

@jorgeAcostaVTEX
Copy link
Contributor Author

Hi @iago1501 ! Thanks for taking a look! That makes sense, but is there a way to tell if a Trade Policy is closed?

@iago1501
Copy link

iago1501 commented Apr 8, 2024

Yep, something like we do here checking the sessionResponse from render-runtime:

https://github.com/vtex-apps/challenge-tp-condition/blob/41d6c2255d0f5fde6a26b543fcf95969e9d47e8c/react/ChallengeTradePolicyCondition.tsx#L76-L87

If the store is closed or B2B, then, only authorized users will access it, and, if that's the case, you will have a condition in the TP that you can check if the user is allowed or not

@iago1501
Copy link

Closing this PR due to lack of interaction, if you want to discuss something else about the implementation, please, feel free to reopen it or let me know 👋🏻

@iago1501 iago1501 closed this Apr 30, 2024
Copy link

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approved due: #42 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants