-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SSR settings #42
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
Hi @jorgeAcostaVTEX , why not simply remove the offers when in closed tp instead of adding an app flag and changing the ssr? Also, I'm not confident about increase server load time just to get the app settings here |
Hi @iago1501 ! Thanks for taking a look! That makes sense, but is there a way to tell if a Trade Policy is closed? |
Yep, something like we do here checking the sessionResponse from render-runtime: If the store is closed or B2B, then, only authorized users will access it, and, if that's the case, you will have a condition in the TP that you can check if the user is allowed or not |
Closing this PR due to lack of interaction, if you want to discuss something else about the implementation, please, feel free to reopen it or let me know 👋🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not approved due: #42 (comment)
What problem is this solving?
Offers still being sent due to SSR settings
How to test it?
Check page source and look for "offers"
Workspace
Screenshots or example usage:
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
![](put .gif link here - can be found under "advanced" on giphy)