-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add async validation on uploading file #150
Feat: add async validation on uploading file #150
Conversation
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
export const bytesToSize = (bytes: number) => { | ||
const sizes = ['Bytes', 'KB', 'MB', 'GB', 'TB'] | ||
|
||
if (bytes === 0) return '0 Bytes' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be translated? In Portuguese I think we use the same term, but not sure if we can guarantee the same for other languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good question! I will ask to translation team and confirm.
10369a3
to
0297eeb
Compare
Signed-off-by: Arthur Andrade <[email protected]>
0297eeb
to
1f75c93
Compare
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
When the first version of Bulk Import was launched, the B2B team quickly realized the need for asynchronous file validation. To achieve this, the route responsible for uploading and validating the file was split into two parts: the first for uploading the file and the second for initiating its validation. This PR integrates b2b-organizations with the new validation routes. The following sequence occurs after the user uploads a new file:
During each request, if an unexpected error occurs, the modal enters a generic error state, allowing the user to restart the process.
How to test it?
Workspace
Screenshots or example usage:
How does this PR make you feel? 🔗
B2BTEAM-1544