fix metrics when using null decoder

vpalmisano · May 9, 2024 · 6104699 · 6104699
1 parent 69ec2d3
commit 6104699
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/scripts/peer-connection-stats.js b/scripts/peer-connection-stats.js
@@ -372,6 +372,7 @@ async function getPeerConnectionStats(
               concealmentEvents,
               insertedSamplesForDeceleration,
               removedSamplesForAcceleration,
+              keyFramesDecoded,
             } = s
             Object.assign(values.inboundRtp, {
               kind,
@@ -402,6 +403,7 @@ async function getPeerConnectionStats(
               concealmentEvents,
               insertedSamplesForDeceleration,
               removedSamplesForAcceleration,
+              keyFramesDecoded,
             })
           } else if (s.type === 'remote-candidate') {
             values.remoteAddress = s.address
@@ -431,7 +433,7 @@ async function getPeerConnectionStats(
             // Update video framesPerSecond.
             if (
               values.inboundRtp.kind === 'video' &&
-              values.inboundRtp.decoderImplementation !== 'NullVideoDecoder'
+              values.inboundRtp.keyFramesDecoded > 0
             ) {
               const frames = positiveDiff(
                 values.inboundRtp.framesReceived,

diff --git a/src/rtcstats.ts b/src/rtcstats.ts
@@ -448,10 +448,7 @@ export function updateRtcStats(
           )
         })
       }
-      if (
-        inboundRtp.kind === 'video' &&
-        inboundRtp.decoderImplementation !== 'unknown'
-      ) {
+      if (inboundRtp.kind === 'video' && inboundRtp.keyFramesDecoded > 0) {
         //setStats(stats, prefix + 'FramesDecoded', key, inboundRtp.framesDecoded
         setStats(
           stats,