Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update release-notes.rst for Teams 2.5.1" #5463

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

findtopher
Copy link
Member

@findtopher findtopher commented Feb 4, 2025

Reverts #5462

release notes should be based on main

Summary by CodeRabbit

  • UI Improvements

    • Analytics and performance notifications now display consistently, enhancing user experience.
  • Documentation Updates

    • Evaluation guides have been refined to offer clearer instructions on IoU calculations and mask usage.
  • Media Handling Enhancements

    • Image and video components now support improved cross-origin loading for smoother media display.

Overall, these updates streamline interactions and improve clarity, benefiting end-user functionality and overall responsiveness.

@findtopher findtopher requested review from a team as code owners February 4, 2025 02:43
Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request applies a broad set of modifications across testing workflows, UI components, documentation, and repository logic. The workflow file is updated with a Node downgrade and streamlined dependency setup. Several components now always render by removing conditional test-specific logic. Looker elements are enhanced with cross-origin settings, and mask decoding functions are simplified by removing extra parameters. Numerous end-to-end test suites have been restructured—removing web server lifecycle hooks—and repository functions are refactored by eliminating log error handling. Documentation and environment variables have also been updated accordingly.

Changes

File(s) Change Summary
.github/workflows/e2e.yml Downgraded Node (22 → 18), removed Python setup and caching, streamlined requirements installation, and added Playwright browser steps.
app/packages/app/src/components/Analytics.tsx,
app/packages/core/src/components/QueryPerformanceToast.tsx
Removed conditional blocks that disabled components in Playwright tests to ensure they always render.
app/packages/looker/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx Removed non-binary classification logic and corresponding metrics; simplified evaluation summary rows.
app/packages/looker/src/elements/.../image.ts,
.../imavid/index.ts,
.../three-d.ts,
.../util.ts
Added crossOrigin = "Anonymous" to images, videos, and 3D elements for proper CORS handling.
app/packages/looker/src/worker/.../canvas-decoder.ts,
.../disk-overlay-decoder.ts,
.../mask-decoder.ts
Removed field and coloring parameters from function signatures, simplifying mask decoding logic by dropping segmentation-specific handling.
app/packages/operators/src/OperatorPalette.tsx Removed the isExecuting property and related conditional logic from the dialog close handling.
app/packages/playback/src/lib/use-timeline-viz-utils.ts Eliminated error-handling condition for division by zero in frame percentage calculation.
app/packages/state/src/recoil/queryPerformance.test.ts,
.../queryPerformance.ts
Removed the isQueryPerformantView selector and consolidated query performance logic into a single selector.
docs/source/release-notes.rst,
docs/source/user_guide/evaluation.rst
Removed release notes for version 2.5.1; updated evaluation documentation and method signatures.
e2e-pw/.env.dev.template,
e2e-pw/README.md
Added FIFTYONE_DATABASE_NAME, removed LOG_PROCESS_OUTPUT, and added instructions for Playwright version mismatches.
e2e-pw/playwright.config.ts,
e2e-pw/scripts/check-flaky.sh,
e2e-pw/scripts/del-pw-dbs.sh
Modified Playwright configuration (timeout, parallelism, workers, channel removal) and improved test script structure; removed obsolete DB deletion script.
e2e-pw/scripts/generate-screenshots-docker-image/Dockerfile Downgraded base image and simplified Python installation commands.
e2e-pw/src/oss/constants/index.ts,
.../fixtures/index.ts,
.../fixtures/loader.ts
Added default app network constants and updated fixture logic to remove web server management, adding loader-based web server control.
e2e-pw/src/oss/specs/... (multiple test spec files) Removed web server start/stop hooks and restructured lifecycle methods; test case signatures and assertions are updated and streamlined.
e2e-pw/src/shared/db-utils/index.ts,
e2e-pw/src/shared/network-utils/index.ts,
e2e-pw/src/shared/network-utils/port.ts
Removed utilities for database deletion and network port availability checking.
fiftyone/constants.py,
fiftyone/factory/repos/...,
fiftyone/operators/delegated.py,
fiftyone/server/events/dispatch.py
Updated COMPATIBLE_VERSIONS (restricting upper limit), removed set_log_upload_error methods and attribute, and eliminated related index creation and return statements in event dispatch.

Sequence Diagram(s)

sequenceDiagram
    participant Loader as fiftyoneLoader
    participant Runner as Test Runner
    participant Grid as Grid Fixture
    participant Modal as Modal Fixture
    Note over Runner, Loader: End-to-end Test Setup (Web server hook removed)
    Runner->>Loader: Execute test.beforeAll() to load dataset
    Loader-->>Runner: Dataset setup complete
    Runner->>Grid: Run test.beforeEach() to wait for grid readiness
    Grid-->>Runner: Grid is loaded
    Runner->>Modal: Perform UI assertions on modals
    Modal-->>Runner: UI interaction verified
Loading

Possibly related PRs

Suggested labels

documentation

Poem

I’m just a happy little bunny,
Hopping through lines of code with glee,
Fixing tests and streamlining paths,
With each change, I feel so free!
Nibbling bugs and crunching bytes 🥕,
Our code now sings in pure delight!
Happy hops to a brighter night!

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@findtopher findtopher enabled auto-merge February 4, 2025 02:44
@findtopher findtopher disabled auto-merge February 4, 2025 02:45
@findtopher findtopher merged commit aeb6e9e into main Feb 4, 2025
11 of 12 checks passed
@findtopher findtopher deleted the revert-5462-jleven-patch-1 branch February 4, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant