Skip to content

Commit

Permalink
fix (build): Do not re-use the GRPC_JAVA_VERSION for the grpc-java mod
Browse files Browse the repository at this point in the history
See VirtusLab/bazel-steward#404 for background.
  • Loading branch information
vorburger committed Mar 3, 2025
1 parent 07c3a11 commit 1300516
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# Nota bene, any shared version numbers defined here should ONLY be
# for Maven versions (of multiple artifacts), and NOT also used in bazel_dep()
# mod versions; because of https://github.com/VirtusLab/bazel-steward/issues/404.

RDF4J_VERSION = "5.1.2"

GRPC_JAVA_VERSION = "1.69.0"
Expand Down Expand Up @@ -48,7 +52,8 @@ switched_rules.use_languages(java = True)
# https://registry.bazel.build/modules/grpc-java
# TODO Bump grpc-java version to avoid ugly WARNING & DEBUG once https://github.com/grpc/grpc-java/issues/11792
# and https://github.com/grpc/grpc-java/issues/11791 are fixed (and released).
bazel_dep(name = "grpc-java", version = GRPC_JAVA_VERSION, repo_name = "io_grpc_grpc_java")
# NB: Do *NOT* re-use GRPC_JAVA_VERSION here, because of https://github.com/VirtusLab/bazel-steward/issues/404.
bazel_dep(name = "grpc-java", version = "1.69.0", repo_name = "io_grpc_grpc_java")

# https://github.com/bazelbuild/rules_go/blob/master/docs/go/core/bzlmod.md
bazel_dep(name = "rules_go", version = "0.51.0")
Expand Down

0 comments on commit 1300516

Please sign in to comment.