Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove false positives Astro check (introduced in seed:docs) #241

Open
wants to merge 1 commit into
base: chore/seed-docs
Choose a base branch
from

Conversation

jbmoelker
Copy link
Member

@jbmoelker jbmoelker commented Jan 4, 2025

Changes

Removes seed script before Astro check runs, as otherwise it's causing a false positive linting error:

config/datocms/scripts/seed-docs.ts:8:57 - error ts(2307): Cannot find module 'datocms-html-to-structured-text' or its corresponding type declarations.

8 import { hastToStructuredText, type HastRootNode } from 'datocms-html-to-structured-text';

The file should not be in scope for Astro check anyway, but I'm unable to exclude it in any other way, nor resolve the linting issue. This fix isn't pretty, but does the job.

Associated issue

Unblocks #231

How to test

Verify all CI checks now pass

Checklist

  • I have performed a self-review of my own code
  • I have made sure that my PR is easy to review (not too big, includes comments)
  • I have made updated relevant documentation files (in project README, docs/, etc)
  • I have added a decision log entry if the change affects the architecture or changes a significant technology
  • I have notified a reviewer

Copy link

Deploying head-start with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6b5d91f
Status: ✅  Deploy successful!
Preview URL: https://120d028e.head-start.pages.dev
Branch Preview URL: https://fix-seed-docs.head-start.pages.dev

View logs

@jbmoelker jbmoelker requested a review from Siilwyn January 4, 2025 05:30
@jbmoelker jbmoelker marked this pull request as ready for review January 4, 2025 05:33
@jbmoelker jbmoelker mentioned this pull request Jan 4, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant