feature: proxy files with custom slugs #224
Conversation
jbmoelker
changed the title
Deploying head-start with
|
| Latest commit: |
d40ec53
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0df38499.head-start.pages.dev |
| Branch Preview URL: | https://feat-proxy-files-with-custom.head-start.pages.dev |
| @@ -10,5 +10,6 @@ fragment FileRoute on FileRecord { | |||
| url | |||
| } | |||
| locale | |||
| customSlug: slug | |||
There was a problem hiding this comment.
required to resolve clashing types with other slug fields on route fragments
There was a problem hiding this comment.
This would also be resolved when renaming the field
| @@ -0,0 +1,37 @@ | |||
| import { defineMiddleware } from 'astro/middleware'; | |||
There was a problem hiding this comment.
Using the new atomic middleware handlers setup introduced in #222 . Should maybe be merged first?
…oede/head-start into feat/proxy-files-with-custom-slugs
| id: 'cnnDYybJTAGvHxiYq2MJ8g', | ||
| label: 'Slug', | ||
| field_type: 'string', | ||
| api_key: 'slug', |
There was a problem hiding this comment.
I think naming this slug is confusing. In my perception, a slug is a human-readable, yet machine-safe path fragment. What is described in the hint, and in the customFields function seems to show a path, not a slug
| environment: datocmsEnvironment, | ||
| }); | ||
|
|
||
| const fileSlugMap = {} as FileSlugMap; |
There was a problem hiding this comment.
| const fileSlugMap = {} as FileSlugMap; | |
| const fileSlugMap: FileSlugMap = {}; |
This is safer than as:
| @@ -10,5 +10,6 @@ fragment FileRoute on FileRecord { | |||
| url | |||
| } | |||
| locale | |||
| customSlug: slug | |||
There was a problem hiding this comment.
This would also be resolved when renaming the field
Changes
Makes files available under custom URLs by
slugfield to the File model./my-files/example.pdfserveshttps://www.datocms-assets.com/145765/1730925112-dummy.pdf.Associated issue
Resolves #155
How to test
Checklist