fix: vite session secrets in github ci (#73)

voltrondata · Feb 6, 2024 · 5308c78 · 5308c78
1 parent 9d207b3
commit 5308c78
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/.github/workflows/deploy-api-client.yml b/.github/workflows/deploy-api-client.yml
@@ -25,16 +25,12 @@ jobs:
     - name: Checkout Repository
       uses: actions/checkout@v4
 
-    - name: Set Environment Variable
-      run: ssh -i ${{ secrets.DEPLOY_SSH_KEY }} ${{ secrets.DEPLOY_USERNAME }}@${{ secrets.DEPLOY_HOST_DNS }} "echo 'export VITE_SESSION_SECRET=${{ secrets.VITE_SESSION_SECRET }}' >> ~/.bashrc"
-
     - uses: matiasnu/github-action-ssh-docker-compose@7fb3aa789f898b63c3722e6beb2dafa1a70f0e22 # v2.0.3
       name: Docker-Compose Remote Deployment
       with:
         ssh_host: ${{ secrets.DEPLOY_HOST_DNS }}
         ssh_private_key: ${{ secrets.DEPLOY_SSH_KEY }}
         ssh_user: ${{ secrets.DEPLOY_USERNAME }}
         docker_compose_prefix: deploy
-      env:
-        VITE_SESSION_SECRET: ${{ secrets.VITE_SESSION_SECRET }}
-        DUCKDB_POOL_SIZE: 5
+        secrets: |
+          "VITE_SESSION_SECRET=${{ secrets.VITE_SESSION_SECRET }}"
diff --git a/docker-compose.yaml b/docker-compose.yaml
@@ -9,23 +9,14 @@ services:
      - DUCKDB_POOL_SIZE=5
     networks:
       - fiddle-network
-    secrets:
-       - VITE_SESSION_SECRET
 
   client:
     build: ./client
     ports:
       - "8080:8080"
     networks:
       - fiddle-network
-    secrets:
-       - VITE_SESSION_SECRET
 
 networks:
   fiddle-network:
     driver: bridge
-
-secrets:
-  VITE_SESSION_SECRET:
-    external: true
-    name: ${{ secrets.VITE_SESSION_SECRET }}