Manage templates per session instead of globally #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the IPFIX specification, a template is specific to a transport session. Observation domains are not guaranteed to be unique across transport sessions. When a transport session is closed (TCP connection closed or UDP session timeout), all associated templates are removed. Note that prior to this change, templates associated to a TCP connection were never cleaned up, causing a memory leak. Signed-off-by: Antonin Bas <[email protected]>
yuntanghsu
reviewed
Dec 9, 2024
Signed-off-by: Antonin Bas <[email protected]>
|
Thanks for the review @yuntanghsu ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the IPFIX specification, a template is specific to a transport session. Observation domains are not guaranteed to be unique across transport sessions.
When a transport session is closed (TCP connection closed or UDP session timeout), all associated templates are removed. Note that prior to this change, templates associated to a TCP connection were never cleaned up, causing a memory leak.