Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable var-declaration from revive #8636

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

mmorel-35
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

enable and fixes var-declaration rule from revive

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot requested a review from sseago January 22, 2025 06:52
@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jan 22, 2025
@mmorel-35 mmorel-35 force-pushed the revive/var-declaration branch from b2eadef to cfe0524 Compare January 22, 2025 06:54
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (a9031eb) to head (cfe0524).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8636   +/-   ##
=======================================
  Coverage   59.39%   59.39%           
=======================================
  Files         370      370           
  Lines       39952    39952           
=======================================
  Hits        23730    23730           
  Misses      14731    14731           
  Partials     1491     1491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sseago sseago merged commit 1e54f1c into vmware-tanzu:main Jan 22, 2025
42 checks passed
@mmorel-35 mmorel-35 deleted the revive/var-declaration branch January 22, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants