-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: apply gofumpt in pkg packages #8613
base: main
Are you sure you want to change the base?
Conversation
/kind changelog-not-required |
0d49227
to
5152550
Compare
file, err := ext.fs.OpenFile(fileName, os.O_RDWR|os.O_CREATE, 0644) | ||
file, err := ext.fs.OpenFile(fileName, os.O_RDWR|os.O_CREATE, 0o644) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reasonerjt @Lyndon-Li thoughts on using this notation for octal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've been using gofmt which is official.
Do wanna us gofumpt which is a fork of gofmt?
I'm tentatively blocking the merge of the PR until the maintainers reach the agreement.
I think we've been using gofmt which is official.
Do wanna us gofumpt which is a fork of gofmt?
I'm tentatively blocking the merge of the PR until the maintainers reach the agreement.
Signed-off-by: Matthieu MOREL <[email protected]>
3a2210a
5152550
to
3a2210a
Compare
Thank you for contributing to Velero!
Please add a summary of your change
chore: apply gofumpt in pkg packages
Activation in golangci-lint config will happen in a later PR
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.