Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply gofumpt in pkg packages #8613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 14, 2025

Thank you for contributing to Velero!

Please add a summary of your change

chore: apply gofumpt in pkg packages

Activation in golangci-lint config will happen in a later PR

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 71.87500% with 27 lines in your changes missing coverage. Please review.

Project coverage is 59.33%. Comparing base (5b1738a) to head (3a2210a).

Files with missing lines Patch % Lines
pkg/controller/pod_volume_restore_controller.go 0.00% 3 Missing ⚠️
...k/backupitemaction/v2/backup_item_action_server.go 25.00% 3 Missing ⚠️
...restoreitemaction/v2/restore_item_action_server.go 0.00% 3 Missing ⚠️
pkg/cmd/util/output/backup_structured_describer.go 0.00% 2 Missing ⚠️
pkg/restore/actions/change_image_name_action.go 0.00% 2 Missing ⚠️
pkg/client/config.go 50.00% 0 Missing and 1 partial ⚠️
pkg/cmd/util/output/backup_describer.go 0.00% 1 Missing ⚠️
pkg/controller/backup_deletion_controller.go 50.00% 1 Missing ⚠️
...g/controller/backup_storage_location_controller.go 0.00% 1 Missing ⚠️
pkg/controller/backup_sync_controller.go 50.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8613   +/-   ##
=======================================
  Coverage   59.33%   59.33%           
=======================================
  Files         370      370           
  Lines       39932    39906   -26     
=======================================
- Hits        23692    23677   -15     
+ Misses      14744    14734   -10     
+ Partials     1496     1495    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kaovilai
kaovilai previously approved these changes Jan 14, 2025
file, err := ext.fs.OpenFile(fileName, os.O_RDWR|os.O_CREATE, 0644)
file, err := ext.fs.OpenFile(fileName, os.O_RDWR|os.O_CREATE, 0o644)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reasonerjt @Lyndon-Li thoughts on using this notation for octal?

Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've been using gofmt which is official.

Do wanna us gofumpt which is a fork of gofmt?

I'm tentatively blocking the merge of the PR until the maintainers reach the agreement.

I think we've been using gofmt which is official.

Do wanna us gofumpt which is a fork of gofmt?

I'm tentatively blocking the merge of the PR until the maintainers reach the agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants