Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing doc: PRs must be associated with an issue #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codegold79
Copy link
Contributor

Description

Include a summary of the change. If this change fixes an issue, indicate that on the Fixes line. Briefly include
relevant context and motivation.

It wasn't clear before that issues are required for every PR submitted, even for trivial PRs like typo/copyright year edits. Make it clear that all PRs need to either fix or update an issue.

Updates #75

Change Details

Check all that apply:

  • New feature
  • Bug fix
  • Non-code change
  • Non-breaking change
  • Breaking change
  • Requires a documentation change

Release Note

How Has This Been Tested?

Describe any testing done to verify changes. Provide enough detail that tests can be reproduced.

Checklist:

  • My code follows the Contribution and Style guidelines of this project
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have added test details that prove my fix is effective or that my feature works

@codegold79 codegold79 force-pushed the issue-75_update-contributor-expectations branch from fe85afa to 7b60e96 Compare April 25, 2023 19:44
@codegold79 codegold79 marked this pull request as ready for review April 25, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants