This repository has been archived by the owner on May 10, 2024. It is now read-only.
mark assembly files as compatible with gc toolchain only #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue vmware-archive#19 shows that building with llvmgo (or gccgo) currently fails with an unclear message. This is because it tries to compile .s files that are using a gc-specific format. A complete solution would introduce .s files that do compile with those alternate toolchains, but at least we'll now have a clearer error (undefined reference to a bunch of functions)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #19 shows that building with llvmgo (or gccgo) currently fails with an unclear message.
This is because it tries to compile .s files that are using a gc-specific format.
A complete solution would introduce .s files that do compile with those alternate toolchains,
but at least we'll now have a clearer error (undefined reference to a bunch of functions)