This repository has been archived by the owner on Sep 16, 2020. It is now read-only.
Allow all outbound traffic no matter what #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
@voor This PR removes a feature to not allow connections outside the vpc. Why is that? |
|
You are correct, this does not allow connections outside the VPC. It also does not allow connections to AWS API endpoints, therefore all Bosh CPI calls fail. |
|
We should fix the feature not remove it. On that, I don't know if there's a easy way to fix |
|
Closing this PR, issue still remains open at https://github.com/pivotal-cf/terraforming-aws/issues/85 just this isn't the best way to fix this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve https://github.com/pivotal-cf/terraforming-aws/issues/85 by allowing outbound traffic even when ops manager is on a private subnet.