-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] add mm_processor_kwargs to extra_body for Qwen2.5-VL #13533
[Misc] add mm_processor_kwargs to extra_body for Qwen2.5-VL #13533
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Thanks, can you update the docs with this example? We don't have to test this as the code is straightforward enough. |
ok, which docs in vLLM should be updated? This case has been updated in our Qwen repo. |
You can add it under Online Serving of this page |
Also, it would be best to verify that your PR works with #13516 once it's merged. |
Currently, only the Qwen2.5-VL model requires passing the |
I think it's okay if you want to include this example in https://github.com/vllm-project/vllm/blob/main/examples/online_serving/openai_chat_completion_client_for_multimodal.py (maybe |
Let's keep it simple and only update this in the README of the Qwen2.5-VL: https://github.com/QwenLM/Qwen2.5-VL. |
I just realized that |
@DarkLight1337 I found that after merging the fix into the main branch, passing the fps parameter through mm_processor_kwargs ( |
Can you try converting it into a tuple inside the processor? |
Another way would be to construct |
@DarkLight1337 I change the |
To follow HF's type hints, let's use |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for the continuous contribution to vLLM!
In Qwen2.5-VL online inference, the
fps
parameter inmm_processor_kwargs
is essential for accurately calculating thesecond_pre_grid_t
value. However, the OpenAI interface currently does not support passingmm_processor_kwargs
viaextra_body
. This PR fixes this problem (the previous issue #11652).You can now interact with the vLLM server using the following example, which has been self-tested and verified to work correctly. If additional test cases are required, please tell me where they should be added. @DarkLight1337
FIX #11652