Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1][BugFix] Add __init__.py to v1/spec_decode/ #13359

Merged
merged 1 commit into from
Feb 16, 2025
Merged

[V1][BugFix] Add __init__.py to v1/spec_decode/ #13359

merged 1 commit into from
Feb 16, 2025

Conversation

WoosukKwon
Copy link
Collaborator

Fixes the bug reported in #12193 (comment)

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 16, 2025
@WoosukKwon WoosukKwon mentioned this pull request Feb 16, 2025
Merged
5 tasks
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 16, 2025
@comaniac comaniac enabled auto-merge (squash) February 16, 2025 16:27
@WoosukKwon WoosukKwon disabled auto-merge February 16, 2025 17:39
@WoosukKwon WoosukKwon merged commit 7b89386 into main Feb 16, 2025
53 of 60 checks passed
@WoosukKwon WoosukKwon deleted the v1-ngram-init branch February 16, 2025 17:39
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
@WoosukKwon @panf2333
[V1][BugFix] Add __init__.py to v1/spec_decode/ (vllm-project#13359)
d41dbe6 
Signed-off-by: Woosuk Kwon <[email protected]>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
@WoosukKwon
[V1][BugFix] Add __init__.py to v1/spec_decode/ (vllm-project#13359)
4588387 
Signed-off-by: Woosuk Kwon <[email protected]>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
@WoosukKwon @kerthcet
[V1][BugFix] Add __init__.py to v1/spec_decode/ (vllm-project#13359)
b2aff0a 
Signed-off-by: Woosuk Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WoosukKwon @comaniac