Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Make interval configurable for logging stats #13275

Closed
wants to merge 0 commits into from
Closed

[Misc] Make interval configurable for logging stats #13275

wants to merge 0 commits into from

Conversation

Sakalya
Copy link

@Sakalya Sakalya commented Feb 14, 2025

This PR adds changes to make "interval" configurable for logging stats.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 14, 2025
markmc
markmc reviewed Feb 14, 2025
View reviewed changes
vllm/config.py Outdated
@@ -3429,3 +3429,9 @@ def get_current_vllm_config() -> VllmConfig:
from vllm.config import VllmConfig
return VllmConfig()
return _current_vllm_config

@dataclass
class LogStatsConfig:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ObservabilityConfig is a fine place for this IMO - see also #13295

vllm/v1/engine/async_llm.py Outdated
@@ -56,7 +57,7 @@ def __init__(
self.stat_loggers: List[StatLoggerBase] = []
if self.log_stats:
self.stat_loggers.extend([
LoggingStatLogger(),
LoggingStatLogger(log_stats_config),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pass in vllm_config

vllm/v1/metrics/loggers.py Outdated
self.prefix_caching_metrics = PrefixCachingMetrics()
if self.log_stats_config.interval:
interval = self.log_stats_config.interval
self.prefix_caching_metrics = PrefixCachingMetrics(interval=interval)

def _local_interval_elapsed(self, now: float) -> bool:
# Log every _LOCAL_LOGGING_INTERVAL_SEC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected this config to change _LOCAL_LOGGING_INTERVAL_SEC

vllm/config.py Outdated
class LogStatsConfig:
"""Log Stats configuration."""

interval: int = 1000 # The default interval for logging stats
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a CLI argument too right?

vllm/v1/metrics/loggers.py Outdated
@@ -28,8 +29,9 @@ def log(self, scheduler_stats: SchedulerStats,

class LoggingStatLogger(StatLoggerBase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this change in V0 too

@Sakalya Sakalya force-pushed the fix_logger_interval branch 2 times, most recently from 34aaa5c to 048c2d3 Compare February 15, 2025 13:29
@mergify mergify bot added documentation Improvements or additions to documentation ci/build frontend structured-output labels Feb 15, 2025
@mergify Mergify
Copy link

mergify bot commented Feb 15, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Sakalya.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@Sakalya Sakalya closed this Feb 15, 2025
@Sakalya Sakalya force-pushed the fix_logger_interval branch from 048c2d3 to 9206b3d Compare February 15, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmc markmc markmc left review comments

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

@youkaichao youkaichao Awaiting requested review from youkaichao

@mgoin mgoin Awaiting requested review from mgoin

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth

@LiuXiaoxuanPKU LiuXiaoxuanPKU Awaiting requested review from LiuXiaoxuanPKU

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337

@simon-mo simon-mo Awaiting requested review from simon-mo

Assignees
No one assigned
Labels
ci/build documentation Improvements or additions to documentation frontend needs-rebase speculative-decoding structured-output v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sakalya @markmc