[Hardware][TPU] improve kv cache update performance in prefill #13176
+61
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TPU is not good at scatter(or index_copy in pytorch), this PR modify the slot_mapping logic to make the kv cache get updated at a page granularity, rather than a token granularity.
Based on the profling, the latency of a prefill step with bs=1 and seq_len=1024 drops from 82ms to 37ms. The kv_cache_update has a ~17x performance improvement.
Potential risk: this change needs the pages assigned to the prefill to be empty.