Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hardware][TPU] improve kv cache update performance in prefill #13176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yaochengji
Copy link
Collaborator

@yaochengji yaochengji commented Feb 12, 2025

TPU is not good at scatter(or index_copy in pytorch), this PR modify the slot_mapping logic to make the kv cache get updated at a page granularity, rather than a token granularity.

Based on the profling, the latency of a prefill step with bs=1 and seq_len=1024 drops from 82ms to 37ms. The kv_cache_update has a ~17x performance improvement.

Potential risk: this change needs the pages assigned to the prefill to be empty.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yaochengji
Copy link
Collaborator Author

Seems the CI failure has nothing to do with my change.

pythonic_tool_parser.py:171] SyntaxError: ':' expected after dictionary key
huggingface_hub.errors.LocalEntryNotFoundError: An error happened while trying to locate the file on the Hub and we cannot find the requested files in the local cache. Please check your connection and try again or make sure your Internet connection is on.

Signed-off-by: Chengji Yao <[email protected]>
@yaochengji yaochengji force-pushed the chengji/increase-slot-size branch from 7437110 to ae8e2e5 Compare February 15, 2025 19:33
@yaochengji yaochengji force-pushed the chengji/increase-slot-size branch from ae8e2e5 to a5207f7 Compare February 15, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant