fix cloud-init schema validation error when {{ growpart_str }} is not empty #432
+6,433
−1,883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factoring Refactor Cluster Autoscaler installation
…st as a YAML structure instead of manipulating it as text
…ml-patching Fix patching autoscaler container
Co-authored-by: darthmaim <[email protected]>
…nto more-refactoring
Add some NAT doc in Setting up a cluster.md
fix installation with adding v before versions
Upgrade `crest` shard
Nginx default ingress class
|
|
Thanks for the PR! It seems that I moved that section to the wrong place in one recent update. Are you using microOS for your cluster? |
|
Yes, I’m using microOS for the cluster nodes. I had to hardcode an extra environment variable into ‘master_install_script.sh’ and generate a new binary to make the installation work, though. Maybe I’ll open a new issue with the details. |
|
That would be nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{ growpart_str }}, when is not empty, breaks cloud-init schema validation.
This is easily fixed by moving {{ growpart_str }} up in the template file.