-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Backup/BackupShard --incremental-from-pos accepts backup name #1662
Conversation
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We only need to update the non-auto-generated pages here as the |
That's what happens when I auto-generate the docs. I've been at it for many PRs now, I'm told this "just works" but clearly I didn't make all these changes manually... |
Looking back at my own comment I don't like how it reads. I'm sorry about that, it gives a wrong impression. At any case, please let me know how to proceed otherwise. |
I did see that but didn't realize that it was still broken. Sorry about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM (although vtctl
in the page's headers feels a bit off now -- we could say vtctld[client] now): https://deploy-preview-1662--vitess.netlify.app/docs/19.0/user-guides/operating-vitess/backup-and-restore/creating-a-backup/#create-an-incremental-backup-with-vtctl
And I approved the vitess PR so as long as we regenerate the docs based on the latest in the PR branch we'll be good.
Thanks!
This branch is a mess. Replacing with a new PR. |
This PR documents the changes in vitessio/vitess#14923,
--incremental-from-pos
accepting a backup name.There is a lot of noise because of SHA signatures. The relevant changes are mostly in
content/en/docs/19.0/user-guides/operating-vitess/backup-and-restore/creating-a-backup.md
and otherwise invtctl
andvtctldclient
docs.