Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Backup/BackupShard --incremental-from-pos accepts backup name #1662

Closed
wants to merge 2 commits into from

Conversation

shlomi-noach
Copy link
Contributor

This PR documents the changes in vitessio/vitess#14923, --incremental-from-pos accepting a backup name.

There is a lot of noise because of SHA signatures. The relevant changes are mostly in content/en/docs/19.0/user-guides/operating-vitess/backup-and-restore/creating-a-backup.md and otherwise in vtctl and vtctldclient docs.

Copy link

netlify bot commented Jan 14, 2024

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 10340ca
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/65a37be7f713b50008e06d7d
😎 Deploy Preview https://deploy-preview-1662--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mattlord mattlord self-requested a review January 17, 2024 20:48
@mattlord
Copy link
Collaborator

mattlord commented Jan 17, 2024

We only need to update the non-auto-generated pages here as the vtctldclient reference pages happen automatically based on the client binary output. I.e. we only need to update the user guide and vtctl[client] pages. Can you please remove the other changes so that it's easier to review?

@mattlord mattlord changed the title Docs: Backup/BackupShard --incremental-from-pos accepts abckup name Docs: Backup/BackupShard --incremental-from-pos accepts backup name Jan 17, 2024
@shlomi-noach
Copy link
Contributor Author

We only need to update the non-auto-generated pages here as the vtctldclient reference pages happen automatically based on the client binary output. I.e. we only need to update the user guide and vtctl[client] pages.

That's what happens when I auto-generate the docs. I've been at it for many PRs now, I'm told this "just works" but clearly I didn't make all these changes manually...

@ajm188
Copy link
Contributor

ajm188 commented Jan 18, 2024

@mattlord see #1602 (comment)

@shlomi-noach
Copy link
Contributor Author

Looking back at my own comment I don't like how it reads. I'm sorry about that, it gives a wrong impression. At any case, please let me know how to proceed otherwise.

@mattlord
Copy link
Collaborator

@mattlord see #1602 (comment)

I did see that but didn't realize that it was still broken. Sorry about that.

Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM (although vtctl in the page's headers feels a bit off now -- we could say vtctld[client] now): https://deploy-preview-1662--vitess.netlify.app/docs/19.0/user-guides/operating-vitess/backup-and-restore/creating-a-backup/#create-an-incremental-backup-with-vtctl

And I approved the vitess PR so as long as we regenerate the docs based on the latest in the PR branch we'll be good.

Thanks!

@shlomi-noach
Copy link
Contributor Author

This branch is a mess. Replacing with a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants