Small planner refactoring #17851
Merged
Small planner refactoring #17851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <[email protected]>
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
systay
added
Type: Internal Cleanup
Component: Query Serving
and removed
NeedsDescriptionUpdate
Signed-off-by: Andres Taylor <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17851 +/- ##
========================================
Coverage 67.44% 67.45%
========================================
Files 1592 1592
Lines 258205 258582 +377
========================================
+ Hits 174151 174431 +280
- Misses 84054 84151 +97 ☔ View full report in Codecov by Sentry. |
arthurschreiber
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
In this file there is still usage of output = compact(ctx, output) at L47
Comment on lines
+701
to
+712
| case *Filter: | ||
| if len(in.Predicates) == 0 { | ||
| return in.Source, Rewrote("filter with no predicates removed") | ||
| } | ||
|
|
||
| other, isFilter := in.Source.(*Filter) | ||
| if !isFilter { | ||
| return in, NoRewrite | ||
| } | ||
| in.Source = other.Source | ||
| in.Predicates = append(in.Predicates, other.Predicates...) | ||
| return in, Rewrote("two filters merged into one") |
There was a problem hiding this comment.
no plan output change, seems we do not have a case for filter over filter.
There was a problem hiding this comment.
this code was in Filter.Compact earlier. I think that was handling it. there's one plan that changes if I remove this code
harshit-gangal
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move most of the code in
Compactimplementations to run as normal push down rewriters instead.Checklist