Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: Support for BETWEEN/NOT BETWEEN filter in VStream #17721

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

VReplication: Support for BETWEEN/NOT BETWEEN filter in VStream #17721

wants to merge 2 commits into from
+179 −1

Conversation

beingnoble03
Copy link
Member

@beingnoble03 beingnoble03 commented Feb 8, 2025 •
edited
Loading

Description

This PR adds support for BETWEEN filter in VStream.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 8, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 8, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 8, 2025
@beingnoble03 beingnoble03 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 8, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 24 lines in your changes missing coverage. Please review.

Project coverage is 67.95%. Comparing base (747c308) to head (9c9eb79).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
.../vt/vttablet/tabletserver/vstreamer/planbuilder.go 72.72% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17721      +/-   ##
==========================================
+ Coverage   67.79%   67.95%   +0.16%     
==========================================
  Files        1587     1586       -1     
  Lines      255829   255261     -568     
==========================================
+ Hits       173427   173463      +36     
+ Misses      82402    81798     -604

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beingnoble03
Copy link
Member Author

Tested this locally using the example local cluster.

@beingnoble03 beingnoble03 marked this pull request as ready for review February 9, 2025 06:31
shlomi-noach
shlomi-noach reviewed Feb 10, 2025
View reviewed changes
go/vt/vttablet/tabletserver/vstreamer/vstreamer_test.go
ts.Run()
}

func TestFilteredNotBetweenOperator(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test, I cannot find where the correctness of the BETWEEN values is validated. i.e. I would expect something to validate that the value 1 is not being copied, the values 2 - 4 are, and that the value 5 is not.

go/vt/vttablet/tabletserver/vstreamer/planbuilder.go
continue
}

// x BETWEEN a AND b => x >= a AND x <= b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify comment:

Suggested change
// x BETWEEN a AND b => x >= a AND x <= b
// `x BETWEEN a AND b` means: `x >= a AND x <= b`

go/vt/vttablet/tabletserver/vstreamer/planbuilder.go
}

if !expr.IsBetween {
// x NOT BETWEEN a AND b => x < a OR x > b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify comment:

Suggested change
// x NOT BETWEEN a AND b => x < a OR x > b
// `x NOT BETWEEN a AND b` means: `x < a OR x > b`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach left review comments

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@beingnoble03 @shlomi-noach