schemadiff: ViewDependencyUnresolvedError lists missing referenced entities

[shlomi-noach]

Description

An enhancement to ViewDependencyUnresolvedError, which is now more detailed and lists the names of missing referenced entities.

Related Issue(s)

#10203

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[dbussink]

If we do this loop, we can already add them to a buffer here as well?

[shlomi-noach]

How do you mean add them to a buffer?

[dbussink]

Something like this (not actually validated, but for the idea):

var buf strings.Builder
for i, entity := range e.MissingReferencedEntities {
    if i > 0 {
           buf.WriteString(", ")
    }
    sqlescape.WriteEscapeID(&buf, entity)
}

[shlomi-noach]

done

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.98%. Comparing base (e08d85c) to head (11d6a38).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17711   +/-   ##
=======================================
  Coverage   67.97%   67.98%           
=======================================
  Files        1586     1586           
  Lines      255218   255173   -45     
=======================================
- Hits       173494   173477   -17     
+ Misses      81724    81696   -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.