-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete VTExplain endpoint in favor of vexplain queries #17706
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: c-r-dev <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: c-r-dev <[email protected]>
Signed-off-by: c-r-dev <[email protected]>
There's still a failure here:
|
Signed-off-by: c-r-dev <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17706 +/- ##
==========================================
+ Coverage 67.79% 67.95% +0.16%
==========================================
Files 1587 1585 -2
Lines 255829 255020 -809
==========================================
- Hits 173427 173306 -121
+ Misses 82402 81714 -688 ☔ View full report in Codecov by Sentry. |
thanks for helping to check , confirm this is resolved now with c37692a |
Description
Delete VTExplain endpoint in favor of vexplain queries.
vtexplain
endpoint on vtadmin was depricated with #12163VTAdmin to use VTGate's vexplain #16412 is fixed (merged to main branch with #17508 )
Related Issue(s)
Fixes #12161
Checklist
Deployment Notes