Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Always make sure to escape all strings (#17649) #17655

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jan 30, 2025

Description

This is a backport of #17649

Copy link
Contributor Author

vitess-bot bot commented Jan 30, 2025

Hello @dbussink, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 17655 -R vitessio/vitess
git reset --hard origin/release-19.0
git cherry-pick -m 1 10d36cbdbc66d80194ac1dcdf7f2fdb41e35a44c

Copy link
Contributor Author

vitess-bot bot commented Jan 30, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v19.0.10 milestone Jan 30, 2025
@dbussink dbussink removed Skip CI Skip CI actions from running Merge Conflict labels Jan 30, 2025
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the backport-17649-to-release-19.0 branch from f65ec1f to 03fa61d Compare January 30, 2025 12:52
@dbussink dbussink marked this pull request as ready for review January 30, 2025 12:52
@dbussink dbussink merged commit 74fc34c into release-19.0 Jan 30, 2025
199 checks passed
@dbussink dbussink deleted the backport-17649-to-release-19.0 branch January 30, 2025 15:58
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (c1374d1) to head (03fa61d).
Report is 1 commits behind head on release-19.0.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 5 Missing ⚠️
go/vt/vttablet/onlineddl/executor.go 0.00% 2 Missing ⚠️
go/vt/vttablet/tabletmanager/vdiff/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #17655      +/-   ##
================================================
- Coverage         65.21%   65.20%   -0.01%     
================================================
  Files              1560     1560              
  Lines            238402   238393       -9     
================================================
- Hits             155483   155454      -29     
- Misses            82919    82939      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants