More logs

Signed-off-by: Rohit Nayak <[email protected]>
vitessio · Feb 10, 2025 · 7587ffd · 7587ffd
1 parent e534e80
commit 7587ffd
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go b/go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go
@@ -730,7 +730,7 @@ func (tp *TablePlan) appendFromRow(buf *bytes2.Buffer, row *querypb.Row) error {
 		log.Warningf("appendFromRow: wrong number of lengths for table %s: got %d lengths for %d fields",
 			tp.TablePlanBuilder.name, len(row.Lengths), len(tp.Fields))
 		for i, fld := range tp.Fields {
-			log.Warningf("appendFromRow: field:: %d:%s/%s", i, fld.Table, fld.Name)
+			log.Warningf("appendFromRow: field:: %d:%s.%s", i, fld.Table, fld.Name)
 		}
 		for i, length := range row.Lengths {
 			log.Warningf("appendFromRow: col length:: %d:%d", i, length)

diff --git a/go/vt/vttablet/tabletmanager/vreplication/vcopier.go b/go/vt/vttablet/tabletmanager/vreplication/vcopier.go
@@ -1066,6 +1066,11 @@ func (vbc *vcopierCopyWorker) execute(ctx context.Context, task *vcopierCopyTask
 			}
 		case vcopierCopyTaskInsertRows:
 			advanceFn = func(ctx context.Context, args *vcopierCopyTaskArgs) error {
+				for i, row := range args.rows {
+					if row == nil || len(row.Lengths) == 0 {
+						log.Infof("In worker.execute, row %d is nil or has zero length %v", i, row)
+					}
+				}
 				if _, err := vbc.insertRows(ctx, args.rows); err != nil {
 					return vterrors.Wrapf(err, "failed inserting rows")
 				}

diff --git a/go/vt/vttablet/tabletmanager/vreplication/vcopier_atomic.go b/go/vt/vttablet/tabletmanager/vreplication/vcopier_atomic.go
@@ -180,7 +180,13 @@ func (vc *vcopier) copyAll(ctx context.Context, settings binlogplayer.VRSettings
 		}
 		// When rowstreamer has finished streaming all rows, we get a callback with empty rows.
 		if len(resp.Rows) == 0 {
+			log.Infof("copyAll: got 0 Rows, copy of table %s is done at lastpk %+v", state.currentTableName, lastpkbv)
 			return nil
+		} else {
+			log.Infof("copyAll: copying %d rows for table %s", len(resp.Rows), tableName)
+			for i, row := range resp.Rows {
+				log.Infof("copyAll: row #%d: #lengths %d, #values %d, %v", i, len(row.Lengths), len(row.Values), row)
+			}
 		}
 		// Get the last committed pk into a loggable form.
 		lastpkbuf, merr := prototext.Marshal(&querypb.QueryResult{

diff --git a/go/vt/vttablet/tabletmanager/vreplication/vplayer.go b/go/vt/vttablet/tabletmanager/vreplication/vplayer.go
@@ -243,7 +243,7 @@ func (vp *vplayer) updateFKCheck(ctx context.Context, flags2 uint32) error {
 		dbForeignKeyChecksEnabled == vp.foreignKeyChecksEnabled /* no change in the state, no need to update */ {
 		return nil
 	}
-	log.Infof("Setting this session's foreign_key_checks to %s", strconv.FormatBool(dbForeignKeyChecksEnabled))
+	log.V(2).Infof("Setting this session's foreign_key_checks to %s", strconv.FormatBool(dbForeignKeyChecksEnabled))
 	if _, err := vp.query(ctx, "set @@session.foreign_key_checks="+strconv.FormatBool(dbForeignKeyChecksEnabled)); err != nil {
 		return fmt.Errorf("failed to set session foreign_key_checks: %w", err)
 	}