Skip to content

Commit

Permalink
operators now use the new type
Browse files Browse the repository at this point in the history 
Signed-off-by: Andres Taylor <[email protected]>
  • Loading branch information
@systay
systay committed Feb 3, 2025
1 parent 3caadfc commit 4e4c29c
Show file tree
Hide file tree
Showing 33 changed files with 76 additions and 80 deletions.
2 changes: 1 addition & 1 deletion go/vt/schemadiff/schema.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1127,7 +1127,7 @@ func (s *Schema) getTableColumnNames(t *CreateTableEntity) (columnNames []*sqlpa
// getViewColumnNames returns the names of aliased columns returned by a given view.
func (s *Schema) getViewColumnNames(v *CreateViewEntity, schemaInformation *declarativeSchemaInformation) ([]*sqlparser.IdentifierCI, error) {
var columnNames []*sqlparser.IdentifierCI
for _, node := range v.Select.GetColumns() {
for _, node := range v.Select.GetColumns().Exprs {
switch node := node.(type) {
case *sqlparser.StarExpr:
if tableName := node.TableName.Name.String(); tableName != "" {
Expand Down
3 changes: 1 addition & 2 deletions go/vt/vtgate/planbuilder/operators/SQL_builder.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,7 @@ func buildProjection(op *Projection, qb *queryBuilder) {
}

if !isSel {
cols := op.GetSelectExprs(qb.ctx)
for _, column := range cols {
for _, column := range op.GetSelectExprs(qb.ctx) {
qb.addProjection(column)
}
}
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/aggregator.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ func (a *Aggregator) GetColumns(ctx *plancontext.PlanningContext) (res []*sqlpar
return truncate(a, a.Columns)
}

func (a *Aggregator) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (a *Aggregator) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return transformColumnsToSelectExprs(ctx, a)
}

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/apply_join.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ func (aj *ApplyJoin) GetColumns(ctx *plancontext.PlanningContext) []*sqlparser.A
return cols
}

func (aj *ApplyJoin) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (aj *ApplyJoin) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return transformColumnsToSelectExprs(ctx, aj)
}

Expand Down
4 changes: 2 additions & 2 deletions go/vt/vtgate/planbuilder/operators/ast_to_op.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ func createOperatorFromUnion(ctx *plancontext.PlanningContext, node *sqlparser.U
rexprs := ctx.SemTable.SelectExprs(node.Right)

unionCols := ctx.SemTable.SelectExprs(node)
union := newUnion([]Operator{opLHS, opRHS}, []sqlparser.SelectExprs{lexprs, rexprs}, unionCols, node.Distinct)
union := newUnion([]Operator{opLHS, opRHS}, []*sqlparser.SelectExprs2{lexprs, rexprs}, unionCols.Exprs, node.Distinct)
return newHorizon(union, node)
}

Expand Down Expand Up @@ -464,7 +464,7 @@ func createSelectionOp(
lock sqlparser.Lock,
) Operator {
selectionStmt := &sqlparser.Select{
SelectExprs: selectExprs,
SelectExprs: &sqlparser.SelectExprs2{Exprs: selectExprs},
From: tableExprs,
Where: where,
OrderBy: orderBy,
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/comments.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func (l *LockAndComment) GetColumns(ctx *plancontext.PlanningContext) []*sqlpars
return l.Source.GetColumns(ctx)
}

func (l *LockAndComment) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (l *LockAndComment) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return l.Source.GetSelectExprs(ctx)
}

Expand Down
8 changes: 4 additions & 4 deletions go/vt/vtgate/planbuilder/operators/delete.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func createDeleteWithInputOp(ctx *plancontext.PlanningContext, del *sqlparser.De
dmls := slice.Map(delOps, func(from dmlOp) Operator {
colsList = append(colsList, from.cols)
for _, col := range from.cols {
selectStmt.SelectExprs = append(selectStmt.SelectExprs, aeWrap(col))
selectStmt.SelectExprs.Exprs = append(selectStmt.SelectExprs.Exprs, aeWrap(col))
}
return from.op
})
Expand Down Expand Up @@ -264,15 +264,15 @@ func createDeleteOperator(ctx *plancontext.PlanningContext, del *sqlparser.Delet
}

func generateOwnedVindexQuery(del *sqlparser.Delete, table TargetTable, ksidCols []sqlparser.IdentifierCI) *sqlparser.Select {
var selExprs sqlparser.SelectExprs
selExprs := &sqlparser.SelectExprs2{}
for _, col := range ksidCols {
colName := makeColName(col, table, sqlparser.MultiTable(del.TableExprs))
selExprs = append(selExprs, aeWrap(colName))
selExprs.Exprs = append(selExprs.Exprs, aeWrap(colName))
}
for _, cv := range table.VTable.Owned {
for _, col := range cv.Columns {
colName := makeColName(col, table, sqlparser.MultiTable(del.TableExprs))
selExprs = append(selExprs, aeWrap(colName))
selExprs.Exprs = append(selExprs.Exprs, aeWrap(colName))
}
}
return &sqlparser.Select{
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/distinct.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func (d *Distinct) GetColumns(ctx *plancontext.PlanningContext) []*sqlparser.Ali
return truncate(d, d.Source.GetColumns(ctx))
}

func (d *Distinct) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (d *Distinct) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return truncate(d, d.Source.GetSelectExprs(ctx))
}

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/filter.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func (f *Filter) GetColumns(ctx *plancontext.PlanningContext) []*sqlparser.Alias
return truncate(f, f.Source.GetColumns(ctx))
}

func (f *Filter) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (f *Filter) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return truncate(f, f.Source.GetSelectExprs(ctx))
}

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/hash_join.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func (hj *HashJoin) GetColumns(*plancontext.PlanningContext) []*sqlparser.Aliase
})
}

func (hj *HashJoin) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (hj *HashJoin) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return transformColumnsToSelectExprs(ctx, hj)
}

Expand Down
8 changes: 4 additions & 4 deletions go/vt/vtgate/planbuilder/operators/horizon.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ func (h *Horizon) FindCol(ctx *plancontext.PlanningContext, expr sqlparser.Expr,
return -1
}

for idx, se := range getFirstSelect(h.Query).SelectExprs {
for idx, se := range getFirstSelect(h.Query).SelectExprs.Exprs {
ae, ok := se.(*sqlparser.AliasedExpr)
if !ok {
panic(vterrors.VT09015())
Expand All @@ -162,7 +162,7 @@ func (h *Horizon) FindCol(ctx *plancontext.PlanningContext, expr sqlparser.Expr,
}

func (h *Horizon) GetColumns(ctx *plancontext.PlanningContext) (exprs []*sqlparser.AliasedExpr) {
for _, expr := range ctx.SemTable.SelectExprs(h.Query) {
for _, expr := range ctx.SemTable.SelectExprs(h.Query).Exprs {
ae, ok := expr.(*sqlparser.AliasedExpr)
if !ok {
panic(vterrors.VT09015())
Expand All @@ -173,8 +173,8 @@ func (h *Horizon) GetColumns(ctx *plancontext.PlanningContext) (exprs []*sqlpars
return exprs
}

func (h *Horizon) GetSelectExprs(*plancontext.PlanningContext) sqlparser.SelectExprs {
return getFirstSelect(h.Query).SelectExprs
func (h *Horizon) GetSelectExprs(*plancontext.PlanningContext) []sqlparser.SelectExpr {
return getFirstSelect(h.Query).SelectExprs.Exprs
}

func (h *Horizon) GetOrdering(ctx *plancontext.PlanningContext) []OrderBy {
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/horizon_expanding.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ func createProjectionWithoutAggr(ctx *plancontext.PlanningContext, qp *QueryProj
}

func newStarProjection(src Operator, qp *QueryProjection) *Projection {
cols := sqlparser.SelectExprs{}
var cols []sqlparser.SelectExpr

for _, expr := range qp.SelectExprs {
_ = sqlparser.Walk(func(node sqlparser.SQLNode) (kontinue bool, err error) {
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/insert.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ func columnMismatch(gen *Generate, ins *sqlparser.Insert, sel sqlparser.TableSta
if origColCount > sel.GetColumnCount() {
sel := getFirstSelect(sel)
var hasStarExpr bool
for _, sExpr := range sel.SelectExprs {
for _, sExpr := range sel.SelectExprs.Exprs {
if _, hasStarExpr = sExpr.(*sqlparser.StarExpr); hasStarExpr {
break
}
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/limit.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (l *Limit) GetColumns(ctx *plancontext.PlanningContext) []*sqlparser.Aliase
return l.Source.GetColumns(ctx)
}

func (l *Limit) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (l *Limit) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return l.Source.GetSelectExprs(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/mirror.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (m *PercentBasedMirror) GetColumns(ctx *plancontext.PlanningContext) []*sql
return m.Operator().GetColumns(ctx)
}

func (m *PercentBasedMirror) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (m *PercentBasedMirror) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return m.Operator().GetSelectExprs(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/operator.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ type (
FindCol(ctx *plancontext.PlanningContext, expr sqlparser.Expr, underRoute bool) int

GetColumns(ctx *plancontext.PlanningContext) []*sqlparser.AliasedExpr
GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs
GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr

ShortDescription() string

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/ordering.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func (o *Ordering) GetColumns(ctx *plancontext.PlanningContext) []*sqlparser.Ali
return truncate(o, o.Source.GetColumns(ctx))
}

func (o *Ordering) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (o *Ordering) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return truncate(o, o.Source.GetSelectExprs(ctx))
}

Expand Down
7 changes: 3 additions & 4 deletions go/vt/vtgate/planbuilder/operators/plan_query.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func (noColumns) FindCol(*plancontext.PlanningContext, sqlparser.Expr, bool) int
panic(vterrors.VT13001("noColumns operators have no column"))
}

func (noColumns) GetSelectExprs(*plancontext.PlanningContext) sqlparser.SelectExprs {
func (noColumns) GetSelectExprs(*plancontext.PlanningContext) []sqlparser.SelectExpr {
panic(vterrors.VT13001("noColumns operators have no column"))
}

Expand Down Expand Up @@ -192,7 +192,7 @@ func tryTruncateColumnsAt(op Operator, truncateAt int) bool {
}
}

func transformColumnsToSelectExprs(ctx *plancontext.PlanningContext, op Operator) sqlparser.SelectExprs {
func transformColumnsToSelectExprs(ctx *plancontext.PlanningContext, op Operator) []sqlparser.SelectExpr {
columns := op.GetColumns(ctx)
if trunc, ok := op.(columnTruncator); ok {
count := trunc.getTruncateColumnCount()
Expand All @@ -201,8 +201,7 @@ func transformColumnsToSelectExprs(ctx *plancontext.PlanningContext, op Operator
}
}

selExprs := slice.Map(columns, func(from *sqlparser.AliasedExpr) sqlparser.SelectExpr {
return slice.Map(columns, func(from *sqlparser.AliasedExpr) sqlparser.SelectExpr {
return from
})
return selExprs
}
16 changes: 8 additions & 8 deletions go/vt/vtgate/planbuilder/operators/projection.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ type (
// ProjCols is used to enable projections that are only valid if we can push them into a route, and we never need to ask it about offsets
ProjCols interface {
GetColumns() []*sqlparser.AliasedExpr
GetSelectExprs() sqlparser.SelectExprs
GetSelectExprs() []sqlparser.SelectExpr
}

// Used when there are stars in the expressions that we were unable to expand
StarProjections sqlparser.SelectExprs
StarProjections []sqlparser.SelectExpr

// Used when we know all the columns
AliasedProjections []*ProjExpr
Expand Down Expand Up @@ -136,8 +136,8 @@ func (sp StarProjections) GetColumns() []*sqlparser.AliasedExpr {
panic(vterrors.VT09015())
}

func (sp StarProjections) GetSelectExprs() sqlparser.SelectExprs {
return sqlparser.SelectExprs(sp)
func (sp StarProjections) GetSelectExprs() []sqlparser.SelectExpr {
return sp
}

func (ap AliasedProjections) GetColumns() []*sqlparser.AliasedExpr {
Expand All @@ -146,7 +146,7 @@ func (ap AliasedProjections) GetColumns() []*sqlparser.AliasedExpr {
})
}

func (ap AliasedProjections) GetSelectExprs() sqlparser.SelectExprs {
func (ap AliasedProjections) GetSelectExprs() []sqlparser.SelectExpr {
return slice.Map(ap, func(from *ProjExpr) sqlparser.SelectExpr {
return aeWrap(from.ColExpr)
})
Expand Down Expand Up @@ -420,12 +420,12 @@ func (p *Projection) GetColumns(*plancontext.PlanningContext) []*sqlparser.Alias
return p.Columns.GetColumns()
}

func (p *Projection) GetSelectExprs(*plancontext.PlanningContext) sqlparser.SelectExprs {
func (p *Projection) GetSelectExprs(*plancontext.PlanningContext) []sqlparser.SelectExpr {
switch cols := p.Columns.(type) {
case StarProjections:
return sqlparser.SelectExprs(cols)
return cols
case AliasedProjections:
var output sqlparser.SelectExprs
var output []sqlparser.SelectExpr
for _, pe := range cols {
ae := &sqlparser.AliasedExpr{Expr: pe.EvalExpr}
if pe.Original.As.NotEmpty() {
Expand Down
10 changes: 5 additions & 5 deletions go/vt/vtgate/planbuilder/operators/query_planning.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ import (
)

func planQuery(ctx *plancontext.PlanningContext, root Operator) Operator {
var selExpr sqlparser.SelectExprs
var selExpr []sqlparser.SelectExpr
if horizon, isHorizon := root.(*Horizon); isHorizon {
sel := getFirstSelect(horizon.Query)
selExpr = sqlparser.Clone(sel.SelectExprs)
selExpr = sqlparser.Clone(sel.SelectExprs).Exprs
}

output := runPhases(ctx, root)
Expand Down Expand Up @@ -805,7 +805,7 @@ func tryPushUnion(ctx *plancontext.PlanningContext, op *Union) (Operator, *Apply
}

var sources []Operator
var selects []sqlparser.SelectExprs
var selects []*sqlparser.SelectExprs2

if op.distinct {
sources, selects = mergeUnionInputInAnyOrder(ctx, op)
Expand All @@ -829,7 +829,7 @@ func tryPushUnion(ctx *plancontext.PlanningContext, op *Union) (Operator, *Apply
}

// addTruncationOrProjectionToReturnOutput uses the original Horizon to make sure that the output columns line up with what the user asked for
func addTruncationOrProjectionToReturnOutput(ctx *plancontext.PlanningContext, selExprs sqlparser.SelectExprs, output Operator) Operator {
func addTruncationOrProjectionToReturnOutput(ctx *plancontext.PlanningContext, selExprs []sqlparser.SelectExpr, output Operator) Operator {
if len(selExprs) == 0 {
return output
}
Expand All @@ -843,7 +843,7 @@ func addTruncationOrProjectionToReturnOutput(ctx *plancontext.PlanningContext, s
return createSimpleProjection(ctx, selExprs, output)
}

func colNamesAlign(expected, actual sqlparser.SelectExprs) bool {
func colNamesAlign(expected, actual []sqlparser.SelectExpr) bool {
if len(expected) > len(actual) {
// if we expect more columns than we have, we can't align
return false
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/queryprojection.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ func createQPFromSelect(ctx *plancontext.PlanningContext, sel *sqlparser.Select)
}

func (qp *QueryProjection) addSelectExpressions(ctx *plancontext.PlanningContext, sel *sqlparser.Select) {
for _, selExp := range sel.SelectExprs {
for _, selExp := range sel.SelectExprs.Exprs {
switch selExp := selExp.(type) {
case *sqlparser.AliasedExpr:
col := SelectExpr{
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/recurse_cte.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func (r *RecurseCTE) GetColumns(ctx *plancontext.PlanningContext) []*sqlparser.A
return r.Seed().GetColumns(ctx)
}

func (r *RecurseCTE) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (r *RecurseCTE) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return r.Seed().GetSelectExprs(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/route.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,7 @@ func (r *Route) GetColumns(ctx *plancontext.PlanningContext) []*sqlparser.Aliase
return truncate(r, r.Source.GetColumns(ctx))
}

func (r *Route) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (r *Route) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return truncate(r, r.Source.GetSelectExprs(ctx))
}

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/subquery.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func (sq *SubQuery) GetColumns(ctx *plancontext.PlanningContext) []*sqlparser.Al
return sq.Outer.GetColumns(ctx)
}

func (sq *SubQuery) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (sq *SubQuery) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return sq.Outer.GetSelectExprs(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/subquery_builder.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ func createComparisonSubQuery(

// if we are comparing with a column from the inner subquery,
// we add this extra predicate to check if the two sides are mergable or not
if ae, ok := subq.Select.GetColumns()[0].(*sqlparser.AliasedExpr); ok {
if ae, ok := subq.Select.GetColumns().Exprs[0].(*sqlparser.AliasedExpr); ok {
subquery.OuterPredicate = &sqlparser.ComparisonExpr{
Operator: sqlparser.EqualOp,
Left: outside,
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/subquery_container.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func (sqc *SubQueryContainer) GetColumns(ctx *plancontext.PlanningContext) []*sq
return sqc.Outer.GetColumns(ctx)
}

func (sqc *SubQueryContainer) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (sqc *SubQueryContainer) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return sqc.Outer.GetSelectExprs(ctx)
}

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/subquery_planning.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ func rewriteColNameToArgument(
default:
// for scalar value subqueries, the argument is typed based on the first expression in the subquery
// so here we make an attempt at figuring out the type of the argument
ae, isAe := sq2.originalSubquery.Select.GetColumns()[0].(*sqlparser.AliasedExpr)
ae, isAe := sq2.originalSubquery.Select.GetColumns().Exprs[0].(*sqlparser.AliasedExpr)
if !isAe {
return sqlparser.NewArgument(s)
}
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/table.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func (to *Table) GetColumns(*plancontext.PlanningContext) []*sqlparser.AliasedEx
return slice.Map(to.Columns, colNameToExpr)
}

func (to *Table) GetSelectExprs(ctx *plancontext.PlanningContext) sqlparser.SelectExprs {
func (to *Table) GetSelectExprs(ctx *plancontext.PlanningContext) []sqlparser.SelectExpr {
return transformColumnsToSelectExprs(ctx, to)
}

Expand Down
Loading

0 comments on commit 4e4c29c

Please sign in to comment.