Added utility functions to update and remove a view #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keller-mark these would need to be added to the docs, once finalized and approved. |
There was a problem hiding this comment.
Could we add some tests for these functions? e.g. extending the cases here: https://github.com/vitessce/vitessce-python/blob/tkakar/cat-907-add-get-view/tests/test_config.py
|
@NickAkhmetov thanks for reviewing. Will add the tests. |
keller-mark
reviewed
Oct 1, 2024
|
It looks very good overall, I would change the naming of these functions and refactor the two into four for clarity, then it is ready to merge |
|
@keller-mark thanks for reviewing. will fix these. |
keller-mark
approved these changes
Oct 2, 2024
"Merged main"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions
get_views(),get_view_by(), andremove_view_byto update or remove a view from the ConfigView.Addresses #104