Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new users-query CLI command lists users who ran sim since a start date #1415

Merged
merged 1 commit into from
Jan 13, 2025
Merged

new users-query CLI command lists users who ran sim since a start date #1415

merged 1 commit into from
Jan 13, 2025

Conversation

jcschaff
Copy link
Member

administrative tool to query the list of users who ran simulations since a given date. user list includes email address, name, userid and whether they agreed to be notified.

@jcschaff jcschaff self-assigned this Jan 10, 2025
@jcschaff jcschaff requested a review from AvocadoMoon January 10, 2025 16:08
AvocadoMoon
AvocadoMoon approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@AvocadoMoon AvocadoMoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good. The command line execution, and writing of results seems reasonable. Only portion that may be of concern is the SQL because it's a lengthy query command leaving room for error, but reading it everything seems okay.

@jcschaff jcschaff merged commit 3e40e24 into master Jan 13, 2025
13 checks passed
@jcschaff jcschaff deleted the user-query-cli branch January 13, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvocadoMoon AvocadoMoon AvocadoMoon approved these changes

Assignees

@jcschaff jcschaff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcschaff @AvocadoMoon