Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

988 n5 export rpc #1047

Merged
merged 51 commits into from
Dec 7, 2023
Merged

988 n5 export rpc #1047

merged 51 commits into from
Dec 7, 2023

Conversation

AvocadoMoon
Copy link
Contributor

I've added functionality for the GUI to send an RPC request to export sim data into an N5 file format, and for that request to be handled by an N5 export service which can finish the request and host it at an S3 endpoint.

Basic GUI that lets you choose compression type before exportation. Has no wiring for GUI.
Refactored the auto generated code conn*To* functions and making them inline.
Refactor most of the automatically generated code within PDEExportDataPanel to help the code become more readable.
Initial code written to allow exporting using the RPC service and write the files where they need to be.
Added functionality of exportation to the java GUI elements.
Allows users to specify the name they want for their dataset.
Forgot to delete a duplicate dependency in the POM file.
Let users decide a time range for the data they are exporting to N5. No longer does it have to be the entire time block.
The order of a functions input was wrong and I fixed it.
Changed the initialization of tests, but not the underlying test itself.
The exporter just writes the data directly to N5 directory, making thing's significantly easier.
Align the files that depend on the N5 export service to work with its new configuration.
Add N5 dir to docker build file
Exports without using the tmp file storage unit
Make N5 and secondary sim data required properties.
Changed the naming scheme of datasets to follow a string template and revised tests to use this naming scheme.
Make the export data be within a singular bucket and have the URL represent where the data is served on the S3Proxy instance.
Make there be no pop-up to download the exported data.
Removed the code for the old export code that didn't go through an RPC service. Also removed functionality of the API calls, making them return nothing for now.
Make tests work with secondary sim data requirement.
@AvocadoMoon AvocadoMoon requested a review from jcschaff November 16, 2023 13:47
@AvocadoMoon AvocadoMoon self-assigned this Nov 16, 2023
@AvocadoMoon AvocadoMoon linked an issue Nov 16, 2023 that may be closed by this pull request
Basic GUI that lets you choose compression type before exportation. Has no wiring for GUI.
Refactored the auto generated code conn*To* functions and making them inline.
Refactor most of the automatically generated code within PDEExportDataPanel to help the code become more readable.
Added functionality of exportation to the java GUI elements.
Allows users to specify the name they want for their dataset.
Forgot to delete a duplicate dependency in the POM file.
Let users decide a time range for the data they are exporting to N5. No longer does it have to be the entire time block.
The order of a functions input was wrong and I fixed it.
Changed the initialization of tests, but not the underlying test itself.
The exporter just writes the data directly to N5 directory, making thing's significantly easier.
Align the files that depend on the N5 export service to work with its new configuration.
Add N5 dir to docker build file
Exports without using the tmp file storage unit
Make N5 and secondary sim data required properties.
Changed the naming scheme of datasets to follow a string template and revised tests to use this naming scheme.
Make the export data be within a singular bucket and have the URL represent where the data is served on the S3Proxy instance.
Make there be no pop-up to download the exported data.
Removed the code for the old export code that didn't go through an RPC service. Also removed functionality of the API calls, making them return nothing for now.
Make tests work with secondary sim data requirement.
Before I used bean utils to cast the format Specs object to N5Specs, now I use atomic type casting.
Before I used bean utils to cast the format Specs object to N5Specs, now I use atomic type casting.
Copy link
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take a look at my comments and adjust the code as you see fit, especially look at the configuration scripts local_xxx.sh and serverconfig-uch.sh.

Added the required N5 env variables for the shell script to function properly.
Fixed the newline in my config file and replaced all string versions of the N5 file suffix with literals.
Copy link
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes were made per suggestions, approved.

@AvocadoMoon AvocadoMoon merged commit 91e4116 into master Dec 7, 2023
12 checks passed
@AvocadoMoon AvocadoMoon deleted the 988-n5-export-rpc branch December 7, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

N5 Export RPC
2 participants