Merge pull request #1432 from virtualcell/fix-CD

Fix Outdated Artifact Function Being Used
virtualcell · Jan 31, 2025 · c726480 · c726480
2 parents cdf2777 + f6a0428
commit c726480
Showing 1 changed file with 16 additions and 8 deletions.
diff --git a/.github/workflows/site_deploy.yml b/.github/workflows/site_deploy.yml
@@ -77,7 +77,7 @@ jobs:
         scp docker/swarm/$VCELL_CONFIG_FILE_NAME ${{ secrets.CD_FULL_USER }}@${VCELL_MANAGER_NODE}:${VCELL_DEPLOY_REMOTE_DIR}
         scp docker/swarm/variables ${{ secrets.CD_FULL_USER }}@${VCELL_MANAGER_NODE}:${VCELL_DEPLOY_REMOTE_DIR}/variables_$VCELL_TAG
     - name: upload variables
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: variables
         path: docker/swarm/variables
@@ -91,7 +91,7 @@ jobs:
         ./generate_installers.sh ./${VCELL_CONFIG_FILE_NAME}
     - name: upload generated installers
       if: ${{ github.event.inputs.server_only != 'true' }}
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: installers
         path: docker/swarm/generated_installers
@@ -107,7 +107,7 @@ jobs:
     steps:
     - name: download generated installers
       if: ${{ github.event.inputs.server_only != 'true' }}
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
     - name: notarize mac installer
       if: ${{ github.event.inputs.server_only != 'true' }}
       run: |
@@ -142,9 +142,9 @@ jobs:
         fi
     - name: update generated installers
       if: ${{ github.event.inputs.server_only != 'true' }}
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
-        name: installers
+        name: updated_installers
         path: installers
         retention-days: 1
     - name: Setup tmate session
@@ -160,15 +160,23 @@ jobs:
       uses: actions/checkout@v4
       with:
         ref: ${{ github.event.inputs.vcell_version }}.${{ github.event.inputs.vcell_build }}
-    - name: retrieve installers and variables
-      uses: actions/download-artifact@v3
+    - name: retrieve installers
+      uses: actions/download-artifact@v4
+      with:
+          name: updated_installers
+          path: updated_installers
+    - name: retrieve variables
+      uses: actions/download-artifact@v4
+      with:
+        name: variables
+        path: variables
     - name: setenv
       run: |
         for line in $(cat variables/variables); do echo $line >> $GITHUB_ENV; done
     - name: stage installers
       if: ${{ github.event.inputs.server_only != 'true' }}
       run: |
-        cd installers
+        cd updated_installers
         mkdir ../docker/swarm/generated_installers
         mv * ../docker/swarm/generated_installers
     - name: setup ssh-agent