validate tickers first #88
Open
+41
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virattt
reviewed
Feb 8, 2025
| Returns a tuple of (is_valid, invalid_tickers). | ||
| """ | ||
| try: | ||
| response = requests.get("https://virattt.github.io/datasets/financials/available_tickers.json") |
There was a problem hiding this comment.
We can just use https://www.sec.gov/files/company_tickers.json
Financial Datasets also has a /tickers/ endpoint for each API, but may be too heavy for now!
There was a problem hiding this comment.
that URL is not working I get:
U.S. Securities and Exchange Commission
Automated access to our sites must comply with SEC.gov's Privacy and Security Policy.
Please visit www.sec.gov/developer for more developer resources and Fair Access guidelines.
Please visit www.sec.gov/privacy for more information on Privacy Policy.
Reference ID: 0.8477d917.1739045494.29945d84
There was a problem hiding this comment.
You may need to add headers since its the SEC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change validates the tickers before executing the API calls to prevent costs when entering an invalid ticker