Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relate bytes to IO specification #216

Merged
merged 39 commits into from
Nov 22, 2023
Merged

Relate bytes to IO specification #216

merged 39 commits into from
Nov 22, 2023

Conversation

mlimbeck
Copy link
Collaborator

Includes helper functions to relate concrete bytes with the abstract representation of the network packet in the IO spec.

jcp19
jcp19 requested changes Jul 18, 2023
View reviewed changes
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
jcp19
jcp19 reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started taking a look at this but I haven't looked at it super in depth. I will do that later this week. I have a few requests already that have to do with readability

router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
jcp19
jcp19 reviewed Jul 30, 2023
View reviewed changes
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, things look good. I wonder if the performance problems that you reported on our last meeting manifest in the code from this PR already

router/dataplane_spec.gobra Outdated Show resolved Hide resolved
verification/io/other_defs.gobra Outdated Show resolved Hide resolved
@jcp19
Copy link
Contributor

jcp19 commented Oct 14, 2023

@mlimbeck can you please give a status update on this PR?

@mlimbeck
Copy link
Collaborator Author

mlimbeck commented Oct 16, 2023 •
edited
Loading

Once we have merged PR #230 I am going to look how we can use the new ghost state DataPlaneSpec to solve the issue with the asid argument in getHopfieldsConsDir() and getHopfieldsNotConsDir().

@mlimbeck mlimbeck mentioned this pull request Nov 14, 2023
Merged
6 tasks
@jcp19 jcp19 requested review from jcp19 and Dspil November 16, 2023 12:06
Dspil
Dspil approved these changes Nov 17, 2023
View reviewed changes
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
@mlimbeck @Dspil
Update router/dataplane_spec.gobra
b051f09 
Co-authored-by: Dionysios Spiliopoulos <[email protected]>
jcp19
jcp19 requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor comments to make this more readable. Should be ready to merge after they are addressed

router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
@jcp19 jcp19 mentioned this pull request Nov 22, 2023
Closed
jcp19
jcp19 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, there are a few minor points that should be addressed before merging. After this is handled and the CI passes, we can merge it

pkg/slayers/path/scion/base_spec.gobra Outdated Show resolved Hide resolved
router/dataplane_spec.gobra Outdated Show resolved Hide resolved
router/io-spec.gobra Outdated Show resolved Hide resolved
pkg/slayers/path/hopfield_spec.gobra Outdated Show resolved Hide resolved
router/io-spec.gobra Outdated Show resolved Hide resolved
@jcp19 jcp19 merged commit 4754d93 into viperproject:master Nov 22, 2023
4 checks passed
@jcp19 jcp19 mentioned this pull request Dec 5, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcp19 jcp19 jcp19 approved these changes

@Dspil Dspil Dspil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlimbeck @jcp19 @Dspil