Set isToggleImportedFromOpticks in the settings object to allow mocki…

…ng in the tests

packages/eslint-plugin/lib/rules/toggle.js

@@ -39,21 +39,18 @@ module.exports = {
   },
 
   create(context) {
-    // QUESTION it seems the test runner reads from `context.settings`
-    // while .eslintrc.js reads from `settings`
+    // The test runner reads from `context.settings`, while .eslintrc.js reads from `settings`
     const settings = context.settings || settings
     const {opticks} = settings
 
-    let isToggleImportedFromOpticks = false
-
     return {
       ImportDeclaration: (node) => {
         const importPath = node.source.value
 
         if (importPath === 'opticks') {
           node.specifiers.forEach((specifier) => {
             if (specifier.imported.name === 'toggle') {
-              isToggleImportedFromOpticks = true
+              settings.isToggleImportedFromOpticks = true
             }
           })
         }
@@ -63,7 +60,7 @@ module.exports = {
           callee: {name}
         } = node
 
-        if (name === 'toggle' && isToggleImportedFromOpticks) {
+        if (name === 'toggle' && settings.isToggleImportedFromOpticks) {
           // Check for invalid number of variants
           if (node.arguments.length === 2) {
             return context.report({

packages/eslint-plugin/tests/lib/rules/toggle.js

@@ -1,8 +1,6 @@
 /**
  * @fileoverview Opticks
- * @author Gerrit
- * @warning These test do not work with the isToggleImportedFromOpticks logic in the rules.
- * To run the test, set isToggleImportedFromOpticks to "true" in the rule.
+ * @author Gerrit Burger
  */
 'use strict'
 
@@ -19,7 +17,9 @@ const rule = require('../../../lib/rules/toggle'),
 
 RuleTester.setDefaultConfig({
   settings: {
-    opticks: {experiments: {foo: 'a', bar: null, baz: 'b'}}
+    opticks: {experiments: {foo: 'a', bar: null, baz: 'b'}},
+    // Mock the import of the toggle function from the opticks package
+    isToggleImportedFromOpticks: true
   }
 })
 const ruleTester = new RuleTester()