-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add expire view count feature #47
add expire view count feature #47
Conversation
@0APOCALYPSE0 can you explain it briefly what do you want to do? |
@vinyashegde So according to this feature, shorten url will get expire after using few number of times. So for example during the creation of url if user provide 5 as a input in expiry count view input field then that shorten url can only be used for 5 Times only after that it will get expire. Reference: I have used expire_at_views property here |
@0APOCALYPSE0 i checked your pr the feature isn't working |
@vinyashegde it should work. I noticed one thing so suppose if you are passing n number then it will expire after n+1 example: pass 3 as a input and you can can use them link 4 times after 4 times it will expire. I don't know why api expire url after n+1 times instead of after n times |
@0APOCALYPSE0 can you make some small changes make a button to enable the view count input field and disable on hide it as optional |
35fc36a
to
3604295
Compare
@vinyashegde added |
@0APOCALYPSE0 i checked your pr the toggle button was not working. I checked it on multiple browsers still its the same Fix it! Refused to execute inline event handler because it violates the following Content Security Policy directive: "script-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-...'), or a nonce ('nonce-...') is required to enable inline execution. Note that hashes do not apply to event handlers, style attributes and javascript: navigations unless the 'unsafe-hashes' keyword is present. |
added toggle button for view count moved click event from html to js
f50067f
to
059c1bc
Compare
@vinyashegde I have moved inline event to js now you will not get extension error Can you tell me the steps how are you testing? |
@0APOCALYPSE0 amazing work🚀 |
Feature - Add expiry view count
#46