Attachments #16
Merged
Attachments #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjsj
commented
Jan 15, 2025
| @@ -22,6 +22,7 @@ module.exports = function (api) { | |||
| }, | |||
| }, | |||
| ], | |||
| "react-native-reanimated/plugin", | |||
There was a problem hiding this comment.
This was missing, I followed https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/getting-started/
fjsj
commented
Jan 15, 2025
components/ChatMessageBubble.tsx
Outdated
| width: 150, | ||
| height: 266, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Some fixed width and height is needed.
pamella
approved these changes
Jan 15, 2025
Comment on lines
+29
to
+31
| if (downloadResult.status !== 200) { | ||
| throw new Error("Failed to download file"); | ||
| } |
There was a problem hiding this comment.
Will the user see this error message? If not, perhaps we could print the status too?
There was a problem hiding this comment.
There's a try-catch where shareFile is called. But it would be good to add the status here to the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image and other attachments. Video player not implemented yet, as I'm having crash issues with expo-video.