Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds setup guide and .env.example file #80

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Adds setup guide and .env.example file #80

merged 4 commits into from
Jun 17, 2024

Conversation

amandasavluchinske
Copy link
Contributor

@amandasavluchinske amandasavluchinske commented Jun 14, 2024

Closes #79

@amandasavluchinske amandasavluchinske requested a review from fjsj June 14, 2024 18:53
.env.example Outdated
TAVILY_API_KEY=your-key-here
FIRECRAWL_API_KEY=your-key-here
LANGCHAIN_API_KEY=your-key-here
LANGCHAIN_TRACING_V2=True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .env.example should be inside example/

In root, I think all we need is OPENAI_API_KEY for now. So maybe have two examples, one in example/ another in root.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sg, will do that

Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but please check comment

@amandasavluchinske
Copy link
Contributor Author

@fjsj I'll wait for you to merge your unification before adjusting this PR

@fjsj
Copy link
Member

fjsj commented Jun 14, 2024

merged! I guess you can now rebase @amandasavluchinske

@amandasavluchinske amandasavluchinske requested a review from fjsj June 17, 2024 12:10
@fjsj fjsj merged commit 73c7805 into main Jun 17, 2024
6 checks passed
@fjsj fjsj deleted the docs/add-dev-setup branch June 17, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add readme dev setup
2 participants