Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all examples to a single Django project #77

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Conversation

fjsj
Copy link
Member

@fjsj fjsj commented Jun 14, 2024

Closes #67

return assistant_cls


def get_single_assistant_info(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll use that in another task to show the assistant proper name in the frontend: #78

raise AIUserNotAllowedError("User is not allowed to delete this message")

return DjangoChatMessageHistory(thread_id=message.thread_id).remove_messages([message.id])
return DjangoChatMessageHistory(thread_id=message.thread_id).remove_messages([str(message.id)])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type error.

path: "/htmx",
element: <Redirect to="/htmx/" />,
},
]);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review.


.mdMessage p {
margin: 0;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reduced the margins:
Screenshot from 2024-06-14 15-33-58

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better!

path("", views.react_index, name="react_index"),
# Catch all for react app:
path("", views.react_index, {"resource": ""}),
path("<path:resource>", views.react_index),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes refreshes on React side.

@@ -52,4 +52,6 @@ def vcr_config():
("x-stainless-runtime-version", None),
],
"before_record_response": clear_response,
# Request must has the same body as the recorded request:
"match_on": ["method", "scheme", "host", "port", "path", "query", "body"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the test breaking when instructions or anything else on prompt changes. cc @amandasavluchinske

example/assets/js/App.tsx Outdated Show resolved Hide resolved
@fjsj fjsj requested a review from pamella June 14, 2024 19:29
Copy link
Contributor

@amandasavluchinske amandasavluchinske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after Pam's suggestions are addressed.

Copy link
Collaborator

@pamella pamella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fjsj fjsj merged commit 6848ae3 into main Jun 14, 2024
6 checks passed
@fjsj fjsj deleted the fix/single-example branch June 14, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join all examples into one
3 participants