Implement Message deletion #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjsj
reviewed
Jun 14, 2024
| Message(thread_id=self._thread_id, message=message_to_dict(message)) | ||
| for message in messages | ||
| ] | ||
| ) | ||
|
|
||
| created_messages = Message.objects.bulk_create(message_objects) |
There was a problem hiding this comment.
I think I small speed up can be gained by creating the messages with empty data first, then actually bulk_updating with "message".
There was a problem hiding this comment.
That means not having message=message_to_dict(message) above, only after creation.
fjsj
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #60
Description
Warning
Ideally, we should delete all existing messages before testing this feature. That's because we are now saving the message ID which is used in the message deletion flow.
Weather Assistant
Screencast.from.13-06-2024.19.09.27.webm