Implement Thread deletion #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjsj
reviewed
Jun 12, 2024
| @@ -11,6 +11,7 @@ | |||
| DEFAULTS = { | |||
| "CAN_CREATE_THREAD_FN": "django_ai_assistant.permissions.allow_all", | |||
| "CAN_VIEW_THREAD_FN": "django_ai_assistant.permissions.allow_all", | |||
| "CAN_DELETE_THREAD_FN": "django_ai_assistant.permissions.allow_all", | |||
There was a problem hiding this comment.
I think we can add a owns_thread permission in permissions.py and use them instead as the defaults for CAN_VIEW_THREAD_FN, CAN_DELETE_THREAD_FN and CAN_CREATE_MESSAGE_FN
fjsj
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #59
Description
Implement thread deletion
Weather
Screencast.from.12-06-2024.17.11.38.webm
Movies
Screencast.from.12-06-2024.17.27.31.webm
RAG
Screencast.from.12-06-2024.17.42.25.webm