Fix: Make thread_id parameter of AIAssistant run method optional #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodbv
commented
Jul 14, 2024
| @@ -12,7 +12,10 @@ | |||
| DEFAULT_DOCUMENT_PROMPT, | |||
| DEFAULT_DOCUMENT_SEPARATOR, | |||
| ) | |||
| from langchain_core.chat_history import BaseChatMessageHistory, InMemoryChatMessageHistory | |||
| from langchain_core.chat_history import ( | |||
There was a problem hiding this comment.
This block was auto-formatted by the pre-commit hook (ruff)
rodbv
commented
Jul 14, 2024
| @@ -295,7 +298,9 @@ def get_message_history(self, thread_id: Any | None) -> BaseChatMessageHistory: | |||
| """ | |||
|
|
|||
| # DjangoChatMessageHistory must be here because Django may not be loaded yet elsewhere: | |||
| from django_ai_assistant.langchain.chat_message_histories import DjangoChatMessageHistory | |||
| from django_ai_assistant.langchain.chat_message_histories import ( | |||
There was a problem hiding this comment.
This block was auto-formatted by the pre-commit hook (ruff)
rodbv
commented
Jul 14, 2024
| @@ -538,7 +543,7 @@ def invoke(self, *args: Any, thread_id: Any | None, **kwargs: Any) -> dict: | |||
| return chain.invoke(*args, **kwargs) | |||
|
|
|||
| @with_cast_id | |||
| def run(self, message: str, thread_id: Any | None, **kwargs: Any) -> str: | |||
| def run(self, message: str, thread_id: Any | None = None, **kwargs: Any) -> str: | |||
rodbv
commented
Jul 14, 2024
| @@ -222,4 +235,9 @@ def tool_a(self, foo: str) -> str: | |||
| assistant = FooAssistant() | |||
|
|
|||
| assert hasattr(assistant, "_method_tools") | |||
| assert [t.name for t in assistant._method_tools] == ["tool_d", "tool_c", "tool_b", "tool_a"] | |||
| assert [t.name for t in assistant._method_tools] == [ | |||
There was a problem hiding this comment.
This block was auto-formatted by the pre-commit hook (ruff)
pamella
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following command in the "Manually calling an AI Assistant" section of the Tutorial is failing:
This PR is to provide a default value for the
thread_idparameter, to make the example work again.It's also including a regression test, but let me know if that's overkill, I can remove it.