Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated index.tsx and home.json with new button text and link #113

Merged
merged 3 commits into from
May 7, 2024
Merged

Updated index.tsx and home.json with new button text and link #113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7d9955
Updated index.tsx and home.json with new button text and link
Yami-Yam Apr 19, 2024
eae1ba7
Survey link and discord invite
Yami-Yam Apr 20, 2024
0223499
lint errors fixed
Yami-Yam May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion locales/en/home.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"hero-p": "Bring your inner creativity with Vignette, the open source modular streaming toolkit for virtual streaming.",
"join-discord-long": "Join our Discord for updates",
"join-discord-short": "Join our Discord",
"join-survey": "Join our Survey",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds too invasive, maybe something more inviting so we can invite them to take the survey like "Can't wait? Let's get to know each other!"

"design-smalltitle": "Overview",
"design-title-line1": "A new way to",
"design-title-line2": "stream",
Expand All @@ -20,4 +21,4 @@
"about-button": "About",
"partners-title": "Our Partners",
"become-partner": "Become a partner"
}
}
8 changes: 4 additions & 4 deletions pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,17 @@ const Home: NextPage<cache> = ({ contributors }) => {
</p>

<Button
href="https://discord.gg/rsPNAxwweg"
href="https://docs.google.com/forms/d/e/1FAIpQLSfqaFTQsKdWxQINWxMgMp_eSy3b37GyiPJhUfKfH-B1Q90dug/viewform"
Copy link
Member

@sr229 sr229 Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure the end of this google form backlinks immediately to our Discord? It would be nice to say "Thank you for taking some time to answer some questions! We have a Discord you can join." after they answered the questionnaire.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm currently working on it. Regarding the survey backlinks to a page with a discord invite link, from what I've looked up, I need access to configure the google forms for that but I'm also not so sure if that's the only way to do that. For now, I've set it up so that when users click on the survey button, it opens in a new tab, and the current page redirects to the one with the discord link. Is that okay?

className=" inline-block sm:hidden"
>
{t(`join-discord-short`)}&rarr;
{t(`join-survey`)}&rarr;
</Button>
<Button
size="large"
href="https://discord.gg/rsPNAxwweg"
href="https://docs.google.com/forms/d/e/1FAIpQLSfqaFTQsKdWxQINWxMgMp_eSy3b37GyiPJhUfKfH-B1Q90dug/viewform"
className=" hidden sm:inline-block"
>
{t(`join-discord-long`)} &rarr;
{t(`join-survey`)} &rarr;
</Button>
</div>
</div>
Expand Down
Loading