-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the import_chapter
method
#58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dsomel21
commented
Oct 27, 2023
@@ -1,5 +1,6 @@ | |||
# frozen_string_literal: true | |||
|
|||
require 'csv' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think I needed this, but apparently I do 🤷🏾
JoelHobson
reviewed
Oct 29, 2023
return if chapter.title == chapter_name | ||
|
||
message = "The name in Book #{book.sequence}, Chapter #{chapter_number} is " + | ||
pastel.bold('presently') + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: You could use string interpolation here instead of +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This method is how we will import chapter translations into the database.
I added the documentation in the code, but I will write it here as well:
HOW IT WORKS:
lib/imports/#{book.sequence}/#{chapter_number}.csv
chapter_number: Integer
e.g.3
@book.import_chapter(3)
.Assuming there is a
3.csv
file in the correct directory, this will import the translations from the CSV into the3
rd chapter of@book
(whichever book it is).EXAMPLE:
Go into the
rails console
and do:This will search for a CSV file at
lib/imports/1/3.csv
(or raise error). The CSV file should have the following columns:Chapter_Number
: IntegerChapter_Name
: StringChhand_Type
: StringTuk
: StringPauri_Number
: IntegerPauri_Translation_EN
: String | NULLTuk_Translation_EN
: String | NULLFootnotes
: String | NULLExtended_Ref
: String | NULLAssigned_Singh
: String | NULLExtended_Meaning
: String | NULLNew Changes
Book
modelChapter
modelCloses #57
How Has This Been Tested?
Screenshots or Videos