-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable supply chain security through npm provenance attestation #8911
Conversation
- Configure GitHub Actions workflow for secure publishing - Enable automatic provenance generation during npm publish - Add integrity verification through Sigstore transparency logs
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8911 +/- ##
=======================================
Coverage 83.72% 83.72%
=======================================
Files 120 120
Lines 8110 8110
Branches 1949 1949
=======================================
Hits 6790 6790
Misses 1320 1320 ☔ View full report in Codecov by Sentry. |
any update? Do you guys want to merge it? |
Sorry for the delay @pupapaik, working through getting a minor version of VJS out today. Merging this now. Thanks for your contribution! |
Congrats on merging your first pull request! 🎉🎉🎉 |
Description
Following the recent Lottie-Player supply chain attack, it's crucial to enhance package security. NPM provenance provides cryptographic proof that this package was built from this repository using GitHub Actions, making supply chain attacks significantly harder. More info in my blog post https://medium.com/exaforce/npm-provenance-the-missing-security-layer-in-popular-javascript-libraries-b50107927008
Specific Changes proposed
Changes the workflow github to publish provenance attestation on https://www.npmjs.com/package/video.js
Requirements Checklist
npm run docs:api
to error