Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update sass and change colour syntax #8894

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Conversation

mister-ben
Copy link
Contributor

Description

Projects using newer versions of sass which have deprecated lighten() will get deprecation warnings.

This updates sass, and switches to color.adjust(). This function is available since dart sass 1.23.0.

Note this would increase the output CSS size, as it will output different colour syntax, .e.g.

<   background-image: linear-gradient(-180deg, #fff 88%, rgb(114.9141509434, 132.7028301887, 159.3858490566) 100%);
---
>   background-image: linear-gradient(-180deg, #fff 88%, #73859f 100%);

Closes #8876

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.76%. Comparing base (19ca3f2) to head (17b1cb5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8894      +/-   ##
==========================================
+ Coverage   83.72%   83.76%   +0.03%     
==========================================
  Files         120      120              
  Lines        8110     8110              
  Branches     1949     1949              
==========================================
+ Hits         6790     6793       +3     
+ Misses       1320     1317       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Nov 4, 2024
Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mister-ben !

@adrums86 adrums86 merged commit 55bb0fd into videojs:main Feb 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass deprecations for colour syntax
3 participants