Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-6152] Downgrade build image requirement #88

Merged
merged 17 commits into from
Jan 10, 2024
Merged

Conversation

njooma
Copy link
Member

@njooma njooma commented Jan 10, 2024

We need to use a build image that is less than ubuntu:22.04. Currently the only image that is greater than that is for aarch64.

This PR makes the aarch64 build image ubuntu:20.04. (The other linux architectures are centos:7)

@njooma njooma requested a review from a team as a code owner January 10, 2024 19:43
@njooma njooma requested review from stuqdog and benjirewis and removed request for a team January 10, 2024 19:43
@njooma njooma force-pushed the RSDK-6152/build-runners branch from 2da558d to d77d23b Compare January 10, 2024 19:45
@njooma
Copy link
Member Author

njooma commented Jan 10, 2024

The working build can be found here: https://github.com/viamrobotics/rust-utils/actions/runs/7479772459

The built library was tested against debian:bullseye, and everything is working!

With the current distribution: OSError: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by /usr/local/lib/python3.9/dist-packages/viam/rpc/libviam_rust_utils.so)`

With this library built from this PR:

2024-01-10 19:15:49,927		INFO	viam.rpc.dial (dial.py:286)	Connecting to socket: /tmp/proxy-XsCd8Ujw.sock	
Resources:
[<viam.proto.common.ResourceName rdk:service:sensors/builtin at 0xffff8ecdf3b0>, <viam.proto.common.ResourceName rdk:service:motion/builtin at 0xffff8ef915e0>, <viam.proto.common.ResourceName rdk:service:data_manager/builtin at 0xffff8fea98b0>, <viam.proto.common.ResourceName rdk:component:board/board at 0xffff8ecf4db0>]
board gpio_pin_by_name return value: <viam.components.board.client.GPIOPinClient object at 0xffff8d10d1f0>

Copy link
Member

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to rerelease rust-utils after this @njooma?

- target: aarch64-unknown-linux-gnu
platform: linux_aarch64
image: ubuntu:20.04
runs-on: buildjet-8vcpu-ubuntu-2204-arm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; smart to put the runs-on in the matrix variables! 🧑‍🔧 .

@njooma njooma merged commit a1b57e3 into main Jan 10, 2024
6 checks passed
@njooma njooma deleted the RSDK-6152/build-runners branch January 10, 2024 20:36
@njooma
Copy link
Member Author

njooma commented Jan 10, 2024

Do you want to rerelease rust-utils after this @njooma?

Yup, I'll do a release this afternoon and get a python prerelease out today as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants